SOE technical guidance update #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kd-ods
reviewed
Oct 9, 2023
There was a problem hiding this comment.
This looks good and builds fine.
I think it's worth adding something to the changelog about this addition. Just a short bullet under a new [Unreleased] > Added subheading, along the lines of:
"Scenario added to 'Representing state-owned enterprises' page covering ownership or control by a regional government."
Also, @Blueskies00 this branch is out of date wrt the main branch. So worth bringing them into sync before any more editing on this branch. Ping me to do that together if nec.
kd-ods
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Updates the technical guidance around SOEs to provide a scenario on modelling ownership or control by a regional state government.
Check "Scenario 2" aligns with the related issue Add documentation to state-owned enterprises guidance about modelling data on SOEs owned or controlled by regional government #447
Check that the other svgs match their text.
@kd-ods
(Closes/Relates to) issue: #447