Skip to content
This repository has been archived by the owner on Mar 17, 2021. It is now read-only.

Remove usages of deprecated Operation.value, don't crash editor on errors #6

Merged
merged 4 commits into from
Jun 7, 2019
Merged

Remove usages of deprecated Operation.value, don't crash editor on errors #6

merged 4 commits into from
Jun 7, 2019

Conversation

aiwenar
Copy link
Collaborator

@aiwenar aiwenar commented Jun 7, 2019

No description provided.

@aiwenar aiwenar requested a review from PiotrKozlowski June 7, 2019 13:45
@aiwenar aiwenar mentioned this pull request Jun 7, 2019
Closed
PiotrKozlowski
PiotrKozlowski approved these changes Jun 7, 2019
View reviewed changes
Copy link

@PiotrKozlowski PiotrKozlowski left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would only add some information after console.error('[slate-counters] error while applying operations:', ex) that counters was reset

@aiwenar aiwenar merged commit 139a071 into master Jun 7, 2019
@aiwenar aiwenar deleted the remove-op-value branch June 7, 2019 15:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@PiotrKozlowski PiotrKozlowski PiotrKozlowski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aiwenar @PiotrKozlowski