feat(ecc): Weierstrass affine curves over complex fields #1127
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the macros so that:
Derivation of
Group
and core ops fromWeierstrassPoint
is in a re-usable macro.WeierstrassPoint
is separate fromFromCompressed
traitNew macro that implements
WeierstrassPoint
onAffinePoint
wrapper using only field intrinsics instead of curve intrinsics: this is necessary for complex curves because we do not yet have intrinsics for curve operations over non-prime fields.Unit tests
Not included but I wish to do in the future:
Field
should really extendIntMod
, butIntMod
has some stuff that is specific to modular integers. I want to splitIntMod
intoIntegralDomain + ModularInteger
and thenField
is just an empty extension ofIntegralDomain
that you implement when you're sure the ring is a field. The functions more specific to our intrinsic implementation go intoModularInteger
.