Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove LOADW2 and STOREW2 #1132

Merged
merged 4 commits into from
Jan 2, 2025
Merged

Conversation

yi-sun
Copy link
Collaborator

@yi-sun yi-sun commented Dec 26, 2024

Closes INT-2622

@yi-sun yi-sun added run-benchmark triggers benchmark workflows on the pr run-benchmark-e2e labels Dec 26, 2024
@yi-sun yi-sun force-pushed the feat/remove-load-store2 branch from ccc205e to 2180a0d Compare January 1, 2025 04:24
@yi-sun yi-sun marked this pull request as draft January 1, 2025 04:25
@yi-sun yi-sun marked this pull request as ready for review January 1, 2025 04:25

This comment has been minimized.

@yi-sun yi-sun force-pushed the feat/remove-load-store2 branch from 1cc55d6 to 3a3ceef Compare January 1, 2025 06:41

This comment has been minimized.

Copy link
Contributor

@jonathanpwang jonathanpwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yi-sun yi-sun force-pushed the feat/remove-load-store2 branch from 3a3ceef to 8062061 Compare January 2, 2025 00:22
@yi-sun yi-sun changed the base branch from main to native-cleanup January 2, 2025 00:35
@yi-sun yi-sun merged commit 12a642c into native-cleanup Jan 2, 2025
13 checks passed
@yi-sun yi-sun deleted the feat/remove-load-store2 branch January 2, 2025 00:36
Copy link

github-actions bot commented Jan 2, 2025

Benchmarks

group app_log_blowup app_total_cells_used app_total_cycles app_total_proof_time_ms leaf_log_blowup leaf_total_cells_used leaf_total_cycles leaf_total_proof_time_ms max_segment_length instance alloc
ecrecover_program
2
15,230,037
290,016
(-24.0 [-1.0%])
2,368.0
2
(+25,154,202 [+5.6%])
470,764,600
(+1,831,426 [+18.7%])
11,607,697
(+13,551.0 [+38.9%])
48,429.0
1048476 64cpu-linux-arm64 mimalloc
fibonacci_program
2
51,505,102
1,500,137
(+65.0 [+1.2%])
5,537.0
2
(+8,591,722 [+6.7%])
137,453,288
(+650,462 [+20.5%])
3,823,151
(-551.0 [-4.0%])
13,248.0
1048476 64cpu-linux-arm64 mimalloc
regex_program
2
165,028,173
4,190,904
(+48.0 [+0.3%])
15,714.0
2
(+16,486,742 [+5.7%])
307,759,387
(+1,220,987 [+18.7%])
7,742,359
(-1,061.0 [-3.9%])
25,925.0
1048476 64cpu-linux-arm64 mimalloc
verify_fibair
2
(+51,066 [+0.6%])
8,063,828
(+30,098 [+15.5%])
224,837
(-85.0 [-5.9%])
1,365.0
-
-
-
-
1048476 64cpu-linux-arm64 mimalloc

E2E Benchmarks

group app_log_blowup app_total_cells_used app_total_cycles app_total_proof_time_ms leaf_log_blowup leaf_total_cells_used leaf_total_cycles leaf_total_proof_time_ms root_log_blowup root_total_cells_used root_total_cycles root_total_proof_time_ms internal_log_blowup internal_total_cells_used internal_total_cycles internal_total_proof_time_ms max_segment_length instance alloc
fib_e2e
2
410,820,430
12,000,137
35,750.0
2
145,159,663
4,156,979
113,155.0
2
816,551,895
22,762,015
80,352.0
2
1,789,365,347
51,503,203
195,760.0
1048476 64cpu-linux-arm64 mimalloc

Commit: 8062061

Benchmark Workflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-benchmark triggers benchmark workflows on the pr run-benchmark-e2e
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants