Skip to content

Commit

Permalink
travis: Drop support.
Browse files Browse the repository at this point in the history
Following a change in the terms of use, free Travis credits are really
too low for a realistic usage by OVS contributors.
As a consequence, testing OVS with Travis has been abandoned by most
(if not all) contributors to the project.

Drop the Travis configuration from our repository, clean references in
the documentation and move GHA specifics to the association yml.

Acked-by: Aaron Conole <[email protected]>
Signed-off-by: David Marchand <[email protected]>
Signed-off-by: Ilya Maximets <[email protected]>
  • Loading branch information
david-marchand authored and igsilya committed Dec 21, 2022
1 parent d5469cb commit 9a86a3d
Show file tree
Hide file tree
Showing 10 changed files with 14 additions and 167 deletions.
31 changes: 3 additions & 28 deletions .ci/linux-build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -7,21 +7,6 @@ CFLAGS_FOR_OVS="-g -O2"
SPARSE_FLAGS=""
EXTRA_OPTS="--enable-Werror"

on_exit() {
if [ $? = 0 ]; then
exit
fi
FILES_TO_PRINT="config.log"
FILES_TO_PRINT="$FILES_TO_PRINT */_build/sub/tests/testsuite.log"

for pr_file in $FILES_TO_PRINT; do
cat "$pr_file" 2>/dev/null
done
}
# We capture the error logs as artifacts in Github Actions, no need to dump
# them via a EXIT handler.
[ -n "$GITHUB_WORKFLOW" ] || trap on_exit EXIT

function install_kernel()
{
if [[ "$1" =~ ^5.* ]]; then
Expand Down Expand Up @@ -98,19 +83,9 @@ function install_kernel()
function install_dpdk()
{
local DPDK_VER=$1
local VERSION_FILE="dpdk-dir/travis-dpdk-cache-version"
local VERSION_FILE="dpdk-dir/cached-version"
local DPDK_OPTS=""
local DPDK_LIB=""

if [ -z "$TRAVIS_ARCH" ] ||
[ "$TRAVIS_ARCH" == "amd64" ]; then
DPDK_LIB=$(pwd)/dpdk-dir/build/lib/x86_64-linux-gnu
elif [ "$TRAVIS_ARCH" == "aarch64" ]; then
DPDK_LIB=$(pwd)/dpdk-dir/build/lib/aarch64-linux-gnu
else
echo "Target is unknown"
exit 1
fi
local DPDK_LIB=$(pwd)/dpdk-dir/build/lib/x86_64-linux-gnu

if [ "$DPDK_SHARED" ]; then
EXTRA_OPTS="$EXTRA_OPTS --with-dpdk=shared"
Expand Down Expand Up @@ -245,7 +220,7 @@ elif [ "$M32" ]; then
# Adding m32 flag directly to CC to avoid any posiible issues with API/ABI
# difference on 'configure' and 'make' stages.
export CC="$CC -m32"
elif [ "$TRAVIS_ARCH" != "aarch64" ]; then
else
OPTS="--enable-sparse"
if [ "$AFXDP" ]; then
# netdev-afxdp uses memset for 64M for umem initialization.
Expand Down
22 changes: 2 additions & 20 deletions .ci/linux-prepare.sh
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,11 @@ fi

# Build and install sparse.
#
# Explicitly disable sparse support for llvm because some travis
# environments claim to have LLVM (llvm-config exists and works) but
# linking against it fails.
# Disabling sqlite support because sindex build fails and we don't
# really need this utility being installed.
git clone git://git.kernel.org/pub/scm/devel/sparse/sparse.git
cd sparse
make -j4 HAVE_LLVM= HAVE_SQLITE= install
make -j4 HAVE_SQLITE= install
cd ..

# Installing wheel separately because it may be needed to build some
Expand All @@ -29,23 +26,8 @@ pip3 install --disable-pip-version-check --user \
flake8 'hacking>=3.0' netaddr pyparsing sphinx setuptools pyelftools
pip3 install --user 'meson==0.53.2'

if [ "$M32" ]; then
# Installing 32-bit libraries.
pkgs="gcc-multilib"
if [ -z "$GITHUB_WORKFLOW" ]; then
# 32-bit and 64-bit libunwind can not be installed at the same time.
# This will remove the 64-bit libunwind and install 32-bit version.
# GitHub Actions doesn't have 32-bit versions of these libs.
pkgs=$pkgs" libunwind-dev:i386 libunbound-dev:i386"
fi

sudo apt-get install -y $pkgs
fi

# Install python test dependencies
pip3 install -r python/test_requirements.txt

# IPv6 is supported by kernel but disabled in TravisCI images:
# https://github.com/travis-ci/travis-ci/issues/8891
# Enable it to avoid skipping of IPv6 related tests.
# Make sure IPv6 is enabled to avoid skipping of IPv6 related tests.
sudo sysctl -w net.ipv6.conf.all.disable_ipv6=0
15 changes: 0 additions & 15 deletions .ci/osx-build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -5,21 +5,6 @@ set -o errexit
CFLAGS="-Werror $CFLAGS"
EXTRA_OPTS=""

on_exit() {
if [ $? = 0 ]; then
exit
fi
FILES_TO_PRINT="config.log"
FILES_TO_PRINT="$FILES_TO_PRINT */_build/sub/tests/testsuite.log"

for pr_file in $FILES_TO_PRINT; do
cat "$pr_file" 2>/dev/null
done
}
# We capture the error logs as artifacts in Github Actions, no need to dump
# them via a EXIT handler.
[ -n "$GITHUB_WORKFLOW" ] || trap on_exit EXIT

function configure_ovs()
{
./boot.sh && ./configure $*
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/build-and-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -133,8 +133,12 @@ jobs:
- name: install common dependencies
run: sudo apt install -y ${{ env.dependencies }}
- name: install libunbound libunwind
# GitHub Actions doesn't have 32-bit versions of these libraries.
if: matrix.m32 == ''
run: sudo apt install -y libunbound-dev libunwind-dev
- name: install 32-bit libraries
if: matrix.m32 != ''
run: sudo apt install -y gcc-multilib

- name: prepare
run: ./.ci/linux-prepare.sh
Expand Down
57 changes: 0 additions & 57 deletions .travis.yml

This file was deleted.

7 changes: 3 additions & 4 deletions Documentation/internals/contributing/submitting-patches.rst
Original file line number Diff line number Diff line change
Expand Up @@ -68,10 +68,9 @@ Testing is also important:
feature. A bug fix patch should preferably add a test that would
fail if the bug recurs.

If you are using GitHub, then you may utilize the travis-ci.org and the GitHub
Actions CI build systems. They will run some of the above tests automatically
when you push changes to your repository. See the "Continuous Integration with
Travis-CI" in :doc:`/topics/testing` for details on how to set it up.
If you are using GitHub, then you may utilize the GitHub Actions CI build
systems. They will run some of the above tests automatically
when you push changes to your repository.

Email Subject
-------------
Expand Down
40 changes: 0 additions & 40 deletions Documentation/topics/testing.rst
Original file line number Diff line number Diff line change
Expand Up @@ -474,46 +474,6 @@ You should invoke scan-view to view analysis results. The last line of output
from ``clang-analyze`` will list the command (containing results directory)
that you should invoke to view the results on a browser.

Continuous Integration with Travis CI
-------------------------------------

A .travis.yml file is provided to automatically build Open vSwitch with various
build configurations and run the testsuite using Travis CI. Builds will be
performed with gcc, sparse and clang with the -Werror compiler flag included,
therefore the build will fail if a new warning has been introduced.

The CI build is triggered via git push (regardless of the specific branch) or
pull request against any Open vSwitch GitHub repository that is linked to
travis-ci.

Instructions to setup travis-ci for your GitHub repository:

1. Go to https://travis-ci.org/ and sign in using your GitHub ID.
2. Go to the "Repositories" tab and enable the ovs repository. You may disable
builds for pushes or pull requests.
3. In order to avoid forks sending build failures to the upstream mailing list,
the notification email recipient is encrypted. If you want to receive email
notification for build failures, replace the encrypted string:

1. Install the travis-ci CLI (Requires ruby >=2.0): gem install travis
2. In your Open vSwitch repository: travis encrypt [email protected]
3. Add/replace the notifications section in .travis.yml and fill in the
secure string as returned by travis encrypt::

notifications:
email:
recipients:
- secure: "....."

.. note::
You may remove/omit the notifications section to fall back to default
notification behaviour which is to send an email directly to the author and
committer of the failing commit. Note that the email is only sent if the
author/committer have commit rights for the particular GitHub repository.

4. Pushing a commit to the repository which breaks the build or the
testsuite will now trigger a email sent to [email protected]

vsperf
------

Expand Down
1 change: 0 additions & 1 deletion Makefile.am
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,6 @@ EXTRA_DIST = \
.ci/osx-prepare.sh \
.cirrus.yml \
.github/workflows/build-and-test.yml \
.travis.yml \
appveyor.yml \
boot.sh \
poc/builders/Vagrantfile \
Expand Down
2 changes: 2 additions & 0 deletions NEWS
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ Post-v3.0.0
* New option '--dump-hugepages' to include hugepages in core dumps. This
can assist with postmortem analysis involving DPDK, but may also produce
significantly larger core dump files.
- Support for travis-ci.org based continuous integration builds has been
dropped.


v3.0.0 - 15 Aug 2022
Expand Down
2 changes: 0 additions & 2 deletions README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@ Open vSwitch

.. image:: https://github.com/openvswitch/ovs/workflows/Build%20and%20Test/badge.svg
:target: https://github.com/openvswitch/ovs/actions
.. image:: https://travis-ci.org/openvswitch/ovs.png
:target: https://travis-ci.org/openvswitch/ovs
.. image:: https://ci.appveyor.com/api/projects/status/github/openvswitch/ovs?branch=master&svg=true&retina=true
:target: https://ci.appveyor.com/project/blp/ovs/history
.. image:: https://api.cirrus-ci.com/github/openvswitch/ovs.svg
Expand Down

0 comments on commit 9a86a3d

Please sign in to comment.