utilities/bashcomp: Do not run ovs-vsctl when not possible.

Bash command completion setup is done during login process. If a command is not available, but it is tried to be run, there is then inconvenient error messages at each login. Signed-off-by: Markus Linnala <[email protected]> Signed-off-by: Simon Horman <[email protected]>
openvswitch · Jan 28, 2025 · ec8fe88 · ec8fe88
1 parent 2472845
commit ec8fe88
Showing 1 changed file with 9 additions and 5 deletions.
diff --git a/utilities/ovs-vsctl-bashcomp.bash b/utilities/ovs-vsctl-bashcomp.bash
@@ -32,11 +32,15 @@ _ovs_vsctl () {
 # A bar (|) character in an argument means thing before bar OR thing
 # after bar; for example, del-port can take a port or an interface.
 
-_OVS_VSCTL_COMMANDS="$(_ovs_vsctl --commands)"
-
-# This doesn't complete on short arguments, so it filters them out.
-_OVS_VSCTL_OPTIONS="$(_ovs_vsctl --options | awk '/^--/ { print $0 }' \
-                      | sed -e 's/\(.*\)=ARG/\1=/')"
+_OVS_VSCTL_COMMANDS=
+_OVS_VSCTL_OPTIONS=
+if command -v ovs-vsctl > /dev/null; then
+    _OVS_VSCTL_COMMANDS="$(_ovs_vsctl --commands)"
+
+    # This doesn't complete on short arguments, so it filters them out.
+    _OVS_VSCTL_OPTIONS="$(_ovs_vsctl --options | awk '/^--/ { print $0 }' \
+                          | sed -e 's/\(.*\)=ARG/\1=/')"
+fi
 IFS=$SAVE_IFS
 
 declare -A _OVS_VSCTL_PARSED_ARGS