Skip to content

Commit

Permalink
ovn-controller.at: Stop hardcoding a list of iface types
Browse files Browse the repository at this point in the history
The list of supported iface types hardcoded in the test
is wrong on NetBSD. (or any userland-only ports I guess)
Instead of adding another case for NetBSD following WIN32,
just get the list from ovsdb.

Signed-off-by: YAMAMOTO Takashi <[email protected]>
Acked-by: Ben Pfaff <[email protected]>
  • Loading branch information
yamt committed Oct 19, 2016
1 parent 04d60f6 commit 8d2b85b
Showing 1 changed file with 1 addition and 7 deletions.
8 changes: 1 addition & 7 deletions tests/ovn-controller.at
Original file line number Diff line number Diff line change
Expand Up @@ -193,13 +193,7 @@ OVS_WAIT_UNTIL([check_datapath_type bar])
ovs-vsctl set Bridge br-int datapath-type=\"\"
OVS_WAIT_UNTIL([check_datapath_type ""])

# The following will need to be updated as OVS starts to support more
# interface types.
if test "$IS_WIN32" = "yes"; then
expected_iface_types="dummy,dummy-internal,dummy-pmd,geneve,gre,internal,lisp,patch,stt,system,vxlan"
else
expected_iface_types="dummy,dummy-internal,dummy-pmd,geneve,gre,internal,lisp,patch,stt,system,tap,vxlan"
fi
expected_iface_types=$(ovs-vsctl get Open_vSwitch . iface_types|sed 's/[[]][[ ]]//g')
chassis_iface_types=$(ovn-sbctl get Chassis ${sysid} external_ids:iface-types | sed -e 's/\"//g')
echo "chassis_iface_types = ${chassis_iface_types}"
AT_CHECK([test "${expected_iface_types}" = "${chassis_iface_types}"])
Expand Down

0 comments on commit 8d2b85b

Please sign in to comment.