Skip to content

Commit

Permalink
bridge: Remove unused macro OFP_PORT_ACTION_WINDOW.
Browse files Browse the repository at this point in the history
I guess that this was missed when the corresponding feature was removed.

Reported-by: David Evans <[email protected]>
Signed-off-by: Ben Pfaff <[email protected]>
Acked-by: Russell Bryant <[email protected]>
  • Loading branch information
blp committed Apr 21, 2015
1 parent 4e311c9 commit f4fa820
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 10 deletions.
1 change: 1 addition & 0 deletions AUTHORS
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,7 @@ Chunhe Li [email protected]
Ciara Loftus [email protected]
Daniel Badea [email protected]
Dave Walker [email protected]
David Evans [email protected]
David Palma [email protected]
Derek Cormier [email protected]
Dhaval Badiani [email protected]
Expand Down
10 changes: 0 additions & 10 deletions vswitchd/bridge.c
Original file line number Diff line number Diff line change
Expand Up @@ -217,16 +217,6 @@ static long long int stats_timer = LLONG_MIN;
#define AA_REFRESH_INTERVAL (1000) /* In milliseconds. */
static long long int aa_refresh_timer = LLONG_MIN;

/* In some datapaths, creating and destroying OpenFlow ports can be extremely
* expensive. This can cause bridge_reconfigure() to take a long time during
* which no other work can be done. To deal with this problem, we limit port
* adds and deletions to a window of OFP_PORT_ACTION_WINDOW milliseconds per
* call to bridge_reconfigure(). If there is more work to do after the limit
* is reached, 'need_reconfigure', is flagged and it's done on the next loop.
* This allows the rest of the code to catch up on important things like
* forwarding packets. */
#define OFP_PORT_ACTION_WINDOW 10

static void add_del_bridges(const struct ovsrec_open_vswitch *);
static void bridge_run__(void);
static void bridge_create(const struct ovsrec_bridge *);
Expand Down

0 comments on commit f4fa820

Please sign in to comment.