Skip to content

Commit

Permalink
build/Dockerfile: skip global typescript, vsce installation
Browse files Browse the repository at this point in the history
We already have vsce and typescript in the project's package.json
and don't need to preinstall them.

Change-Id: Idf4484a3b5662d9509c3146737d6d448bd9c8771
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/506656
TryBot-Result: kokoro <[email protected]>
Reviewed-by: Suzy Mueller <[email protected]>
Run-TryBot: Hyang-Ah Hana Kim <[email protected]>
  • Loading branch information
hyangah committed Jun 28, 2023
1 parent 0de0e11 commit 5f5a875
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
3 changes: 1 addition & 2 deletions build/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,7 @@ ENV DEBIAN_FRONTEND noninteractive
ENV NODE_OPTIONS --dns-result-order=ipv4first

RUN apt-get -qq update && apt-get install -qq -y libnss3 libgtk-3-dev libxss1 libasound2 xvfb libsecret-1-0 jq > /dev/null
RUN npm install -g typescript @vscode/vsce

USER node
WORKDIR /workspace
ENTRYPOINT ["build/all.bash"]
ENTRYPOINT ["build/all.bash"]
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
],
"scripts": {
"clean": "rm -rf ./dist/* && rm *.vsix",
"package": "vsce package",
"package": "npx vsce package",
"vscode:prepublish": "npm run compile",
"bundle": "esbuild src/goMain.ts debugAdapter=src/debugAdapter/goDebug.ts --bundle --outdir=dist --external:vscode --format=cjs --platform=node",
"bundle-dev": "npm run bundle -- --sourcemap",
Expand Down

0 comments on commit 5f5a875

Please sign in to comment.