Skip to content

Commit

Permalink
vscode-go: add strict typecheck step to CI
Browse files Browse the repository at this point in the history
Test files are excluded from strict typechecking. We plan
to fix errors in those files as needed or remove the tests
with the legacy tooling.

For golang#57.

Change-Id: I84ea8bc1834e2e1ee58c297fed984bb94ec0de52
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/403775
TryBot-Result: kokoro <[email protected]>
Run-TryBot: Jamal Carvalho <[email protected]>
Auto-Submit: Jamal Carvalho <[email protected]>
Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
  • Loading branch information
jamalc authored and gopherbot committed May 3, 2022
1 parent 01cc238 commit 8abfcaa
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 0 deletions.
1 change: 1 addition & 0 deletions build/all.bash
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ run_test() {
echo "**** Run test ****"
df -h | grep shm
npm ci
npm run typecheck
npm run compile
npm run unit-test
npm test --silent
Expand Down
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
"bundle-dev": "npm run bundle -- --sourcemap",
"bundle-watch": "npm run bundle -- --sourcemap --watch",
"test-compile": "tsc -p ./tsconfig.build.json",
"typecheck": "tsc -p ./tsconfig.strict.json --noEmit",
"compile": "npm run bundle",
"watch": "tsc -watch -p ./tsconfig.build.json",
"test": "npm run test-compile && node ./out/test/runTest.js",
Expand Down
8 changes: 8 additions & 0 deletions tsconfig.strict.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"extends": "./tsconfig.json",
"exclude": [
"node_modules",
"third_party",
"test"
]
}

0 comments on commit 8abfcaa

Please sign in to comment.