Skip to content

Commit

Permalink
X86TTI: i16/i32 vector div with a constant (splat) divisor are reason…
Browse files Browse the repository at this point in the history
…ably cheap now.

Turn vectorization back on.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@207320 91177308-0d34-0410-b5e6-96231b3b80d8
  • Loading branch information
d0k committed Apr 26, 2014
1 parent 9f2c218 commit d9ced71
Show file tree
Hide file tree
Showing 2 changed files with 111 additions and 0 deletions.
19 changes: 19 additions & 0 deletions lib/Target/X86/X86TargetTransformInfo.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -284,6 +284,21 @@ unsigned X86TTI::getArithmeticInstrCost(unsigned Opcode, Type *Ty,
int ISD = TLI->InstructionOpcodeToISD(Opcode);
assert(ISD && "Invalid opcode");

static const CostTblEntry<MVT::SimpleValueType>
AVX2UniformConstCostTable[] = {
{ ISD::SDIV, MVT::v16i16, 6 }, // vpmulhw sequence
{ ISD::UDIV, MVT::v16i16, 6 }, // vpmulhuw sequence
{ ISD::SDIV, MVT::v8i32, 15 }, // vpmuldq sequence
{ ISD::UDIV, MVT::v8i32, 15 }, // vpmuludq sequence
};

if (Op2Info == TargetTransformInfo::OK_UniformConstantValue &&
ST->hasAVX2()) {
int Idx = CostTableLookup(AVX2UniformConstCostTable, ISD, LT.second);
if (Idx != -1)
return LT.first * AVX2UniformConstCostTable[Idx].Cost;
}

static const CostTblEntry<MVT::SimpleValueType> AVX2CostTable[] = {
// Shifts on v4i64/v8i32 on AVX2 is legal even though we declare to
// customize them to detect the cases where shift amount is a scalar one.
Expand Down Expand Up @@ -351,6 +366,10 @@ unsigned X86TTI::getArithmeticInstrCost(unsigned Opcode, Type *Ty,
{ ISD::SRA, MVT::v16i8, 4 }, // psrlw, pand, pxor, psubb.
{ ISD::SRA, MVT::v8i16, 1 }, // psraw.
{ ISD::SRA, MVT::v4i32, 1 }, // psrad.

{ ISD::SDIV, MVT::v8i16, 6 }, // pmulhw sequence
{ ISD::UDIV, MVT::v8i16, 6 }, // pmulhuw sequence
{ ISD::UDIV, MVT::v4i32, 15 }, // pmuludq sequence
};

if (Op2Info == TargetTransformInfo::OK_UniformConstantValue &&
Expand Down
92 changes: 92 additions & 0 deletions test/Analysis/CostModel/X86/vdiv-cost.ll
Original file line number Diff line number Diff line change
@@ -0,0 +1,92 @@
; RUN: opt < %s -mtriple=x86_64-unknown-linux-gnu -mcpu=corei7 -mattr=+sse2,-sse4.1 -cost-model -analyze | FileCheck %s -check-prefix=CHECK -check-prefix=SSE2
; RUN: opt < %s -mtriple=x86_64-unknown-linux-gnu -mcpu=core-avx2 -cost-model -analyze | FileCheck %s -check-prefix=CHECK -check-prefix=AVX2

define <4 x i32> @test1(<4 x i32> %a) {
%div = udiv <4 x i32> %a, <i32 7, i32 7, i32 7, i32 7>
ret <4 x i32> %div

; CHECK: 'Cost Model Analysis' for function 'test1':
; SSE2: Found an estimated cost of 15 for instruction: %div
; AVX2: Found an estimated cost of 15 for instruction: %div
}

define <8 x i32> @test2(<8 x i32> %a) {
%div = udiv <8 x i32> %a, <i32 7, i32 7, i32 7, i32 7,i32 7, i32 7, i32 7, i32 7>
ret <8 x i32> %div

; CHECK: 'Cost Model Analysis' for function 'test2':
; SSE2: Found an estimated cost of 30 for instruction: %div
; AVX2: Found an estimated cost of 15 for instruction: %div
}

define <8 x i16> @test3(<8 x i16> %a) {
%div = udiv <8 x i16> %a, <i16 7, i16 7, i16 7, i16 7, i16 7, i16 7, i16 7, i16 7>
ret <8 x i16> %div

; CHECK: 'Cost Model Analysis' for function 'test3':
; SSE2: Found an estimated cost of 6 for instruction: %div
; AVX2: Found an estimated cost of 6 for instruction: %div
}

define <16 x i16> @test4(<16 x i16> %a) {
%div = udiv <16 x i16> %a, <i16 7, i16 7, i16 7, i16 7,i16 7, i16 7, i16 7, i16 7, i16 7, i16 7, i16 7, i16 7,i16 7, i16 7, i16 7, i16 7>
ret <16 x i16> %div

; CHECK: 'Cost Model Analysis' for function 'test4':
; SSE2: Found an estimated cost of 12 for instruction: %div
; AVX2: Found an estimated cost of 6 for instruction: %div
}

define <8 x i16> @test5(<8 x i16> %a) {
%div = sdiv <8 x i16> %a, <i16 7, i16 7, i16 7, i16 7, i16 7, i16 7, i16 7, i16 7>
ret <8 x i16> %div

; CHECK: 'Cost Model Analysis' for function 'test5':
; SSE2: Found an estimated cost of 6 for instruction: %div
; AVX2: Found an estimated cost of 6 for instruction: %div
}

define <16 x i16> @test6(<16 x i16> %a) {
%div = sdiv <16 x i16> %a, <i16 7, i16 7, i16 7, i16 7,i16 7, i16 7, i16 7, i16 7, i16 7, i16 7, i16 7, i16 7,i16 7, i16 7, i16 7, i16 7>
ret <16 x i16> %div

; CHECK: 'Cost Model Analysis' for function 'test6':
; SSE2: Found an estimated cost of 12 for instruction: %div
; AVX2: Found an estimated cost of 6 for instruction: %div
}

define <16 x i8> @test7(<16 x i8> %a) {
%div = sdiv <16 x i8> %a, <i8 7, i8 7, i8 7, i8 7,i8 7, i8 7, i8 7, i8 7, i8 7, i8 7, i8 7, i8 7,i8 7, i8 7, i8 7, i8 7>
ret <16 x i8> %div

; CHECK: 'Cost Model Analysis' for function 'test7':
; SSE2: Found an estimated cost of 320 for instruction: %div
; AVX2: Found an estimated cost of 320 for instruction: %div
}

define <4 x i32> @test8(<4 x i32> %a) {
%div = sdiv <4 x i32> %a, <i32 7, i32 7, i32 7, i32 7>
ret <4 x i32> %div

; CHECK: 'Cost Model Analysis' for function 'test8':
; SSE2: Found an estimated cost of 15 for instruction: %div
; AVX2: Found an estimated cost of 15 for instruction: %div
}

define <8 x i32> @test9(<8 x i32> %a) {
%div = sdiv <8 x i32> %a, <i32 7, i32 7, i32 7, i32 7,i32 7, i32 7, i32 7, i32 7>
ret <8 x i32> %div

; CHECK: 'Cost Model Analysis' for function 'test9':
; SSE2: Found an estimated cost of 30 for instruction: %div
; AVX2: Found an estimated cost of 15 for instruction: %div
}

define <8 x i32> @test10(<8 x i32> %a) {
%div = sdiv <8 x i32> %a, <i32 8, i32 7, i32 7, i32 7,i32 7, i32 7, i32 7, i32 7>
ret <8 x i32> %div

; CHECK: 'Cost Model Analysis' for function 'test10':
; SSE2: Found an estimated cost of 160 for instruction: %div
; AVX2: Found an estimated cost of 160 for instruction: %div
}

0 comments on commit d9ced71

Please sign in to comment.