Skip to content

Commit

Permalink
[mle] revert request network data on child reattach after reboot (ope…
Browse files Browse the repository at this point in the history
…nthread#2466) (openthread#2486)

This reverts commit 87d8940.

Adding Network Data to the MLE Child Update Response message increases the
message size beyond what can fit in a single IEEE 802.15.4 frame.  The
Thread specification requires all fragmented MLE message to have MAC
security enabled.
  • Loading branch information
jwhui authored Jan 18, 2018
1 parent 5028d2f commit c59da51
Showing 1 changed file with 2 additions and 6 deletions.
8 changes: 2 additions & 6 deletions src/core/thread/mle.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1806,18 +1806,14 @@ otError Mle::SendChildUpdateRequest(void)
switch (mRole)
{
case OT_DEVICE_ROLE_DETACHED:
{
static const uint8_t tlvs[] = {Tlv::kNetworkData};

for (uint8_t i = 0; i < sizeof(mParentRequest.mChallenge); i++)
{
mParentRequest.mChallenge[i] = static_cast<uint8_t>(otPlatRandomGet());
}

SuccessOrExit(error = AppendChallenge(*message, mParentRequest.mChallenge, sizeof(mParentRequest.mChallenge)));
SuccessOrExit(error = AppendTlvRequest(*message, tlvs, sizeof(tlvs)));
SuccessOrExit(error = AppendChallenge(*message, mParentRequest.mChallenge,
sizeof(mParentRequest.mChallenge)));
break;
}

case OT_DEVICE_ROLE_CHILD:
SuccessOrExit(error = AppendSourceAddress(*message));
Expand Down

0 comments on commit c59da51

Please sign in to comment.