replace moment.js in bower_components by ember-moment

[lancedikson]

Hi, again :) now I propose to replace moment.js that install in bower_components by ember-moment addon.

The main reason is getting work ember-moment in the main project dependent on ember-moment and ember-youtube at the same time. Now this collaboration impossible because moment.js required by ember-youtube redefine moment.js required by ember-moment for the main app. And all i18n settings has broken by the reason of redefining moment variable. And when ember-moment trying to get moment it gets ember-youtube's moment because it's global variable.

The second reason is that ember-moment gives ES2015-shim for global moment var to you. Since you can import moment to your project anywhere like I did it in the PR's commit.

moment-duration-format works fine anyway.

[lancedikson]

@oskarrough, ping :)

[oskarrough]

Hi! This looks fine, however I'm considering completely removing the Moment dependency as most people don't need this feature. In ember-youtube it's only used for the timestamps

Instead we could update the readme and explain how to create custom timestamps with moment. What do you think?

[lancedikson]

@oskarrough yeah, I think it could be pretty good solution. Did you mean remove support durationFormatted and currentTimeFormatted from the plugin and describe how users can do this stuff by himself, right?

[oskarrough]

Exactly. To make it a bit smaller. OK for you?

I won't have time to look at it before next week but you're of course
always welcome to help :)

On Tue, Feb 2, 2016 at 9:50 AM Denis Demchenko [email protected]
wrote:

@oskarrough https://github.com/oskarrough yeah, I think it could be
pretty good solution. Do you mean remove support durationFormatted and
currentTimeFormatted from the plugin and describe how users can do this
stuff by himself, right?

—
Reply to this email directly or view it on GitHub
#27 (comment)
.

[lancedikson]

Ok, I’m gonna do it on the week.

On 02 Feb 2016, at 12:25, Oskar [email protected] wrote:

Exactly. To make it a bit smaller. OK for you?

I won't have time to look at it before next week but you're of course
always welcome to help :)

On Tue, Feb 2, 2016 at 9:50 AM Denis Demchenko [email protected]
wrote:

@oskarrough https://github.com/oskarrough yeah, I think it could be
pretty good solution. Do you mean remove support durationFormatted and
currentTimeFormatted from the plugin and describe how users can do this
stuff by himself, right?

—
Reply to this email directly or view it on GitHub
#27 (comment)
.

—
Reply to this email directly or view it on GitHub #27 (comment).