Fix dependencies #53
Merged
Fix dependencies #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
0xadada
commented
Apr 29, 2019
0xadada
commented
- resolves ember-concurrency should be a dependency #52
- adds new LTS releases to ember-try scenarios
added 3 commits
April 29, 2019 12:00
This package doesn't list ember-concurrency as a dependency, but it should, since the youtube component it exposes directly consumes it. fixes #52
|
The only failing test on travis is |
|
Very cool, thank you for this! Should we mark |
|
@oskarrough sure thing. Fixed in 6631bc6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.