Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add search endpoint method #53

Closed
wants to merge 2 commits into from
Closed

Add search endpoint method #53

wants to merge 2 commits into from

Conversation

mr-devs
Copy link
Member

@mr-devs mr-devs commented Feb 16, 2021

Originally, I was going to try and build a more structured framework that allowed users to pass, for example, a list of keywords or hashtags or cashtags (etc.), and then have the method build the query. However, building something that can capture the entire functionality of the endpoint package seems like serious overkill. Furthermore, I toyed with the idea of providing some sort of simple functionality (like being able to accept a list of keywords), however, I think this makes things more confusing.

Instead, I provided a lot of details in the docstring which should be sufficient for anyone with half an idea.

This way the user can build the query themselves and pass it directly to the method.

Note: the tests.py document now includes a test that utilizes an endpoint that is only available for those with academic track access! You can simply comment out line 130 in the file and run that way to test without this level of access.

@mr-devs mr-devs added enhancement New feature or request test labels Feb 16, 2021
@mr-devs mr-devs requested a review from yang3kc February 16, 2021 20:16
@mr-devs mr-devs self-assigned this Feb 16, 2021
@mr-devs mr-devs mentioned this pull request Feb 16, 2021
3 tasks
@mr-devs mr-devs linked an issue Feb 17, 2021 that may be closed by this pull request
3 tasks
@mr-devs mr-devs added this to the Basic functionality milestone Feb 18, 2021
@mr-devs
Copy link
Member Author

mr-devs commented Feb 26, 2021

Subsequent testing revealed a few bugs in the rate_limit_manager.py script. The temp-mix branch is more up to date. I'm going to close this and the rate limit branch branch because they are behind that one.

@mr-devs mr-devs closed this Feb 26, 2021
@mr-devs mr-devs deleted the search branch March 11, 2021 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Historical Search Endpoint
1 participant