Skip to content

Commit

Permalink
Merge branch 'QA_3_4'
Browse files Browse the repository at this point in the history
  • Loading branch information
roccivic committed Dec 7, 2011
2 parents 3813b62 + 2f342d7 commit 9bb001b
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 0 deletions.
1 change: 1 addition & 0 deletions ChangeLog
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ phpMyAdmin - ChangeLog
- bug #3306875 [edit] Can't rename a database that contains views
- bug #3452506 [edit] Unable to move tables with triggers
- bug #3449659 [navi] Fast filter broken with table tree
- bug #3448485 [GUI] Firefox favicon frameset regression

3.4.8.0 (2011-12-01)
- bug #3425230 [interface] enum data split at space char (more space to edit)
Expand Down
12 changes: 12 additions & 0 deletions js/update-location.js
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,23 @@ function setURLHash(hash)
}
if (hash_init_done) {
window.location.hash = "PMAURL:" + hash;
fix_favicon();
} else {
hash_to_set = "PMAURL:" + hash;
}
}
}

// Fix favicon disappearing in Firefox when setting location.hash
// See bug #3448485
function fix_favicon() {
if (jQuery.browser.mozilla) {
// Move the link tags for the favicon to the bottom
// of the head element to force a reload of the favicon
$('head > link[href=\\.\\/favicon\\.ico]').appendTo('head');
}
}

/**
* Handler for changing url according to the hash part, which is updated
* on each page to allow bookmarks.
Expand All @@ -56,6 +67,7 @@ $(document).ready(function(){
if (hash_to_set != "") {
window.location.hash = hash_to_set;
hash_to_set = "";
fix_favicon();
}
/* Indicate that we're done (and we are not going to change location */
hash_init_done = 1;
Expand Down

0 comments on commit 9bb001b

Please sign in to comment.