Remove new-cap ESLint exclusion (prebid#1442)

* Removed the new-cap lint exclusion. * Removed the exclusion from the test directory as well.
osyoyu · Aug 1, 2017 · be3fe46 · be3fe46
1 parent 68511f9
commit be3fe46
Show file tree

Hide file tree

Showing 11 changed files with 28 additions and 30 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -23,7 +23,6 @@ module.exports = {
     "camelcase": "off",
     "eqeqeq": "off",
     "import/first": "off",
-    "new-cap": "off",
     "no-control-regex": "off",
     "no-redeclare": "off",
     "no-return-assign": "off",

diff --git a/modules/adbundBidAdapter.js b/modules/adbundBidAdapter.js
@@ -5,7 +5,7 @@ var bidmanager = require('src/bidmanager.js');
 var adloader = require('src/adloader');
 var adaptermanager = require('src/adaptermanager');
 
-var adBundAdapter = function adBundAdapter() {
+function AdBundAdapter() {
   var timezone = (new Date()).getTimezoneOffset();
   var bidAPIs = [
     'http://us-east-engine.adbund.xyz/prebid/ad/get',
@@ -62,8 +62,8 @@ var adBundAdapter = function adBundAdapter() {
   return {
     callBids: _callBids
   };
-};
+}
 
-adaptermanager.registerBidAdapter(new adBundAdapter(), 'adbund');
+adaptermanager.registerBidAdapter(new AdBundAdapter(), 'adbund');
 
-module.exports = adBundAdapter;
+module.exports = AdBundAdapter;
diff --git a/modules/mobfoxBidAdapter.js b/modules/mobfoxBidAdapter.js
@@ -5,7 +5,7 @@ const CONSTANTS = require('src/constants.json');
 const utils = require('src/utils.js');
 const adaptermanager = require('src/adaptermanager');
 
-const mobfoxAdapter = function () {
+function MobfoxAdapter() {
   const BIDDER_CODE = 'mobfox';
   const BID_REQUEST_BASE_URL = 'https://my.mobfox.com/request.php';
 
@@ -178,7 +178,7 @@ const mobfoxAdapter = function () {
   return {
     callBids: callBids
   };
-};
+}
 
-adaptermanager.registerBidAdapter(new mobfoxAdapter(), 'mobfox');
-module.exports = mobfoxAdapter;
+adaptermanager.registerBidAdapter(new MobfoxAdapter(), 'mobfox');
+module.exports = MobfoxAdapter;
diff --git a/modules/sekindoUMBidAdapter.js b/modules/sekindoUMBidAdapter.js
@@ -1,13 +1,13 @@
 import { getBidRequest } from 'src/utils.js';
+
 var CONSTANTS = require('src/constants.json');
 var utils = require('src/utils.js');
 var bidfactory = require('src/bidfactory.js');
 var bidmanager = require('src/bidmanager.js');
 var adloader = require('src/adloader.js');
 var adaptermanager = require('src/adaptermanager');
 
-var sekindoUMAdapter;
-sekindoUMAdapter = function sekindoUMAdapter() {
+function SekindoUMAdapter() {
   function _callBids(params) {
     var bids = params.bids;
     var bidsCount = bids.length;
@@ -83,8 +83,8 @@ sekindoUMAdapter = function sekindoUMAdapter() {
   return {
     callBids: _callBids
   };
-};
+}
 
-adaptermanager.registerBidAdapter(new sekindoUMAdapter(), 'sekindoUM');
+adaptermanager.registerBidAdapter(new SekindoUMAdapter(), 'sekindoUM');
 
-module.exports = sekindoUMAdapter;
+module.exports = SekindoUMAdapter;
diff --git a/modules/ucfunnelBidAdapter.js b/modules/ucfunnelBidAdapter.js
@@ -8,7 +8,7 @@ import adaptermanager from 'src/adaptermanager';
 const VER = 'ADGENT_PREBID-2017051801';
 const UCFUNNEL_BIDDER_CODE = 'ucfunnel';
 
-function ucfunnelAdapter() {
+function UcfunnelAdapter() {
   function _callBids(params) {
     let bids = params.bids || [];
 
@@ -92,6 +92,6 @@ function ucfunnelAdapter() {
   };
 };
 
-adaptermanager.registerBidAdapter(new ucfunnelAdapter(), UCFUNNEL_BIDDER_CODE);
+adaptermanager.registerBidAdapter(new UcfunnelAdapter(), UCFUNNEL_BIDDER_CODE);
 
-module.exports = ucfunnelAdapter;
+module.exports = UcfunnelAdapter;
diff --git a/modules/unrulyBidAdapter.js b/modules/unrulyBidAdapter.js
@@ -77,7 +77,7 @@ function createBidResponseHandler(bidRequestBids) {
   }
 }
 
-function createUnrulyAdapter() {
+function UnrulyAdapter() {
   const adapter = {
     exchangeUrl: 'https://targeting.unrulymedia.com/prebid',
     callBids({ bids: bidRequestBids }) {
@@ -106,6 +106,6 @@ function createUnrulyAdapter() {
   return adapter
 }
 
-adaptermanager.registerBidAdapter(new createUnrulyAdapter(), 'unruly')
+adaptermanager.registerBidAdapter(new UnrulyAdapter(), 'unruly')
 
-module.exports = createUnrulyAdapter
+module.exports = UnrulyAdapter
diff --git a/test/.eslintrc.js b/test/.eslintrc.js
@@ -26,7 +26,6 @@ module.exports = {
     "no-unused-expressions": "off",
     "import/no-duplicates": "off",
     "no-template-curly-in-string": "off",
-    "new-cap": "off",
     "no-global-assign": "off",
     "no-path-concat": "off",
     "no-redeclare": "off",

diff --git a/test/spec/modules/aardvarkBidAdapter_spec.js b/test/spec/modules/aardvarkBidAdapter_spec.js
@@ -1,6 +1,6 @@
 describe('aardvark adapter tests', function () {
   const expect = require('chai').expect;
-  const adapter = require('modules/aardvarkBidAdapter');
+  const Adapter = require('modules/aardvarkBidAdapter');
   const bidmanager = require('src/bidmanager');
   const adloader = require('src/adloader');
   const constants = require('src/constants.json');
@@ -92,7 +92,7 @@ describe('aardvark adapter tests', function () {
     ];
 
   beforeEach(() => {
-    aardvark = new adapter();
+    aardvark = new Adapter();
     sandbox = sinon.sandbox.create();
     bidsRequestedOriginal = $$PREBID_GLOBAL$$._bidsRequested;
     $$PREBID_GLOBAL$$._bidsRequested = [];

diff --git a/test/spec/modules/mantisBidAdapter_spec.js b/test/spec/modules/mantisBidAdapter_spec.js
@@ -2,15 +2,15 @@
 
 describe('mantis adapter tests', function () {
   const expect = require('chai').expect;
-  const adapter = require('modules/mantisBidAdapter');
+  const Adapter = require('modules/mantisBidAdapter');
   const bidmanager = require('src/bidmanager');
   const adloader = require('src/adloader');
   const constants = require('src/constants.json');
 
   var mantis, sandbox;
 
   beforeEach(() => {
-    mantis = new adapter();
+    mantis = new Adapter();
     sandbox = sinon.sandbox.create();
   });
 

diff --git a/test/spec/modules/rhythmoneBidAdapter_spec.js b/test/spec/modules/rhythmoneBidAdapter_spec.js
@@ -1,4 +1,4 @@
-var r1 = require('../../../modules/rhythmoneBidAdapter');
+var Adapter = require('../../../modules/rhythmoneBidAdapter');
 var assert = require('assert');
 
 describe('rhythmone adapter tests', function () {
@@ -31,7 +31,7 @@ describe('rhythmone adapter tests', function () {
     var endEvent = function() {},
       wonEvent = function() {}; ;
 
-    var z = new r1(
+    var z = new Adapter(
       {
         addBidResponse: function(placementcode, adResponse) {
           it('should echo placementcode div-gpt-ad-1438287399331-0', function() {

diff --git a/test/spec/modules/sekindoUMBidAdapter_spec.js b/test/spec/modules/sekindoUMBidAdapter_spec.js
@@ -1,5 +1,5 @@
 import {expect} from 'chai';
-import sekindoUMAdapter from '../../../modules/sekindoUMBidAdapter';
+import SekindoUMAdapter from '../../../modules/sekindoUMBidAdapter';
 var bidManager = require('src/bidmanager');
 
 describe('sekindoUM Adapter Tests', () => {
@@ -21,7 +21,7 @@ describe('sekindoUM Adapter Tests', () => {
   };
 
   beforeEach(() => {
-    _sekindoUMAdapter = new sekindoUMAdapter();
+    _sekindoUMAdapter = new SekindoUMAdapter();
   });
 
   describe('sekindoUM callBids', () => {
@@ -46,7 +46,7 @@ describe('sekindoUM Adapter Tests', () => {
     beforeEach(function () {
       addBidResponseSpy = sinon.stub(bidManager, 'addBidResponse');
       $$PREBID_GLOBAL$$._bidsRequested.push(bidderRequest);
-      _sekindoUMAdapter = new sekindoUMAdapter();
+      _sekindoUMAdapter = new SekindoUMAdapter();
     });
 
     afterEach(function () {