fix: depotchest memory leak

[lyuz1n]

Pull Request Prelude

• I have followed proper The Forgotten Server code styling.
• I have read and understood the contribution guidelines before making this PR.
• I am aware that this PR may be closed if the above-mentioned criteria are not fulfilled.

Changes Proposed

items on depot cannot destroy after player logout.
after some relogins with around 100k items on depot...

BEFORE FIX:

AFTER FIX:

[nekiro]

#3423
#3452

[moviebr]

Nice :)

[nekiro]

This will crash, because of double pointer deletion, one happens from container destructor, because depot is a regular item inside locker (you have to remove depot from locker on player destructor to avoid that) and the second will trigger from shared_ptr trying to delete assigned object

[ranisalt]

@nekiro is right, if you're going to change to a shared ptr, you must change it everywhere or you will get nasty double frees

[ramon-bernardo]

I ran some tests, and it seems that the code below solves this issue 👇🏻

Player::~Player()
{
	for (auto [_, depotChest] : depotChests) {
		delete depotChest;
	}
}

[nekiro]

superseded by #4879