Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing spectators include #4869

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Conversation

nekiro
Copy link
Member

@nekiro nekiro commented Dec 9, 2024

Pull Request Prelude

Changes Proposed

Add missing include, because it apparently fails to find SpectatorVec in map.cpp/h

Issues addressed:
Master branch doesn't compile

11:57:16:406	1>C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.41.34120\include\utility(459,10): error C2079: 'std::pair<const Position,SpectatorVec>::second' uses undefined class 'SpectatorVec'
11:57:16:485	1>(compiling source file '/theforgo.A10F9657/x64/Debug/unity_4QKKRKOVXFEDFVS0.cpp')
11:57:16:485	1>    C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.41.34120\include\utility(459,10):
11:57:16:485	1>    the template instantiation context (the oldest one first) is
11:57:16:485	1>        D:\repos\forgottenserver-fork\src\map.h(260,17):

How to test:
Try to compile

@ArturKnopik
Copy link
Contributor

ArturKnopik commented Dec 18, 2024

Tested without fix and it's working
Release build passed also.

commit 2b1c699ac94abb5ea415e8acab94f575a109b46e (HEAD, nekiro/fix-compile)
Author: Marcin Jałocha <[email protected]>
Date:   Mon Dec 9 11:57:55 2024 +0100

Add missing spectators include

image

@edit: found source of issue, it's broken normal build, after fixing it's looks like this fix is required

@ArturKnopik ArturKnopik merged commit 0adb986 into otland:master Dec 18, 2024
16 checks passed
@nekiro nekiro deleted the fix-compile branch December 21, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants