prevent fd leakage when WorkerUtils.downloadFromBookkeeper (apache#4970)

Fixes apache#4969 ### Motivation close `FileOutputStream` after `WorkerUtils.downloadFromBookkeeper`
ouyanghuangzheng · Aug 18, 2019 · 2c21500 · 2c21500
1 parent 93d95c7
commit 2c21500
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/...r-functions/worker/src/main/java/org/apache/pulsar/functions/worker/FunctionActioner.java b/...r-functions/worker/src/main/java/org/apache/pulsar/functions/worker/FunctionActioner.java
@@ -219,10 +219,14 @@ private void downloadFile(File pkgFile, boolean isPkgUrlProvided, FunctionMetaDa
         if(downloadFromHttp) {
             FunctionCommon.downloadFromHttpUrl(pkgLocationPath, tempPkgFile);
         } else {
+            FileOutputStream tempPkgFos = new FileOutputStream(tempPkgFile);
             WorkerUtils.downloadFromBookkeeper(
                     dlogNamespace,
-                    new FileOutputStream(tempPkgFile),
+                    tempPkgFos,
                     pkgLocationPath);
+            if (tempPkgFos != null) {
+                tempPkgFos.close();
+            }
         }
 
         try {