Skip to content

Commit

Permalink
[tests] Scope the dependencies for spark and storm tests to test scope (
Browse files Browse the repository at this point in the history
apache#4556)

*Motivation*

In gitsha b7a5677 , it introduced a provided dependency for pulsar-storm-test, which it will fail release process. Since it will attempt to transfer the pom file for  `com.twitter:carbonite:pom:1.5.0` which is a dependency comes from storm-server.

*Changes*

Make all the dependencies scoped at test scope for two test modules. So maven release will not attempt to release them.
  • Loading branch information
sijie authored Jun 18, 2019
1 parent 4c352f0 commit 5f5b609
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 8 deletions.
18 changes: 11 additions & 7 deletions tests/pulsar-spark-test/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -36,16 +36,18 @@
<dependencies>

<dependency>
<groupId>org.apache.pulsar</groupId>
<artifactId>pulsar-spark</artifactId>
<version>${project.version}</version>
<groupId>org.apache.pulsar</groupId>
<artifactId>pulsar-spark</artifactId>
<version>${project.version}</version>
<scope>test</scope>
</dependency>

<dependency>
<groupId>org.apache.pulsar.tests</groupId>
<artifactId>integration</artifactId>
<version>${project.version}</version>
<type>test-jar</type>
<scope>test</scope>
</dependency>

<dependency>
Expand All @@ -55,13 +57,15 @@
</dependency>

<dependency>
<groupId>org.mockito</groupId>
<artifactId>mockito-core</artifactId>
<groupId>org.mockito</groupId>
<artifactId>mockito-core</artifactId>
<scope>test</scope>
</dependency>

<dependency>
<groupId>org.apache.spark</groupId>
<artifactId>spark-streaming_2.10</artifactId>
<groupId>org.apache.spark</groupId>
<artifactId>spark-streaming_2.10</artifactId>
<scope>test</scope>
</dependency>

</dependencies>
Expand Down
8 changes: 7 additions & 1 deletion tests/pulsar-storm-test/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
<groupId>org.apache.pulsar</groupId>
<artifactId>pulsar-storm</artifactId>
<version>${project.version}</version>
<scope>test</scope>
<exclusions>
<exclusion>
<groupId>org.apache.pulsar</groupId>
Expand All @@ -51,7 +52,7 @@
<groupId>org.apache.storm</groupId>
<artifactId>storm-server</artifactId>
<version>${storm.version}</version>
<scope>provided</scope>
<scope>test</scope>
<exclusions>
<exclusion>
<groupId>ch.qos.logback</groupId>
Expand All @@ -68,20 +69,23 @@
<groupId>org.apache.pulsar</groupId>
<artifactId>pulsar-broker</artifactId>
<version>${project.version}</version>
<scope>test</scope>
</dependency>

<dependency>
<groupId>org.apache.pulsar</groupId>
<artifactId>pulsar-broker</artifactId>
<version>${project.version}</version>
<type>test-jar</type>
<scope>test</scope>
</dependency>

<dependency>
<groupId>org.apache.pulsar</groupId>
<artifactId>managed-ledger-original</artifactId>
<version>${project.version}</version>
<type>test-jar</type>
<scope>test</scope>
</dependency>

<dependency>
Expand All @@ -92,12 +96,14 @@
<dependency>
<groupId>org.asynchttpclient</groupId>
<artifactId>async-http-client</artifactId>
<scope>test</scope>
</dependency>

<dependency>
<groupId>org.apache.storm</groupId>
<artifactId>storm-core</artifactId>
<version>${storm.version}</version>
<scope>test</scope>
<exclusions>
<exclusion>
<groupId>ch.qos.logback</groupId>
Expand Down

0 comments on commit 5f5b609

Please sign in to comment.