Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make bun resolve to given file path when an absolute path is given #114

Merged
merged 2 commits into from
Dec 9, 2024
Merged

Make bun resolve to given file path when an absolute path is given #114

merged 2 commits into from
Dec 9, 2024

Conversation

fbarbare
Copy link
Contributor

@fbarbare fbarbare commented Dec 9, 2024

Sometimes we want the bun version to resolve to a package.json (or other) that is not in the default GITHUB_WORKSPACE directory and to do that we can allow to pass an absolute path as the file param which would then ignore the GITHUB_WORKSPACE path.

@fbarbare fbarbare marked this pull request as ready for review December 9, 2024 15:35
xhyrom
xhyrom approved these changes Dec 9, 2024
View reviewed changes
Copy link
Collaborator

@xhyrom xhyrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@xhyrom xhyrom merged commit f09eb1e into oven-sh:main Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xhyrom xhyrom xhyrom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fbarbare @xhyrom