fixes Vincit#2135

ovos · Nov 5, 2021 · 33a03cf · 33a03cf
1 parent bd16a7e
commit 33a03cf
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/lib/relations/RelationOwner.js b/lib/relations/RelationOwner.js
@@ -71,9 +71,11 @@ class RelationOwner {
       if (values) {
         builder.whereInComposite(relatedRefs, values);
       } else {
+        builder.where(false);
         builder.resolve([]);
       }
     } else {
+      builder.where(false);
       builder.resolve([]);
     }
 

diff --git a/tests/integration/find.js b/tests/integration/find.js
@@ -2410,6 +2410,18 @@ module.exports = (session) => {
           });
         });
 
+        it('should return undefined if the model has no parents', async () => {
+          const parent = await Model1.query().findById(2);
+
+          const result1 = await parent.$relatedQuery('model1Relation1').debug();
+          expect(result1).to.be.equal(undefined);
+
+          const result2 = await Model1.relatedQuery('model1Relation1')
+            .for(Model1.relatedQuery('model1Relation1').for(parent))
+            .debug();
+          expect(result2).to.eql([]);
+        });
+
         describe('knex methods', () => {
           it('.select()', () => {
             return parent1