common/utxo: don't memleak script.

We currently always free the tx, so we didn't notice, but the coming changes uncovered this leak. Signed-off-by: Rusty Russell <[email protected]>
owldock · Jun 6, 2019 · ffa8463 · ffa8463
1 parent 0543149
commit ffa8463
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/common/utxo.c b/common/utxo.c
@@ -1,5 +1,6 @@
 #include <bitcoin/script.h>
 #include <common/key_derive.h>
+#include <common/utils.h>
 #include <common/utxo.h>
 #include <wire/wire.h>
 
@@ -60,7 +61,7 @@ struct bitcoin_tx *tx_spending_utxos(const tal_t *ctx,
 	for (size_t i = 0; i < tal_count(utxos); i++) {
 		if (utxos[i]->is_p2sh && bip32_base) {
 			bip32_pubkey(bip32_base, &key, utxos[i]->keyindex);
-			script = bitcoin_scriptsig_p2sh_p2wpkh(tx, &key);
+			script = bitcoin_scriptsig_p2sh_p2wpkh(tmpctx, &key);
 		} else {
 			script = NULL;
 		}