Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nexus-types] cleanup: remove now-unused dataset address field #7451

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

jgallagher
Copy link
Contributor

Tiny little cleanup: after the recent dataset work, there are no longer any consumers of DurableDataset::address, so this PR removes that field.

Copy link
Contributor

@andrewjstone andrewjstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woooooohoooo 🎉

@jgallagher jgallagher merged commit 547118d into main Jan 31, 2025
16 checks passed
@jgallagher jgallagher deleted the john/remove-durable-dataset-address branch January 31, 2025 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants