Merge pull request sushi-labs#11 from Gabriel-GW/reentrant

fix re-entrant risk
p0o · Oct 23, 2020 · 1e4db47 · 1e4db47
2 parents ebee2c5 + 6fc393a
commit 1e4db47
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/contracts/MasterChef.sol b/contracts/MasterChef.sol
@@ -239,10 +239,11 @@ contract MasterChef is Ownable {
     function emergencyWithdraw(uint256 _pid) public {
         PoolInfo storage pool = poolInfo[_pid];
         UserInfo storage user = userInfo[_pid][msg.sender];
-        pool.lpToken.safeTransfer(address(msg.sender), user.amount);
-        emit EmergencyWithdraw(msg.sender, _pid, user.amount);
+        uint256 amount = user.amount;
         user.amount = 0;
         user.rewardDebt = 0;
+        pool.lpToken.safeTransfer(address(msg.sender), amount);
+        emit EmergencyWithdraw(msg.sender, _pid, amount);
     }
 
     // Safe sushi transfer function, just in case if rounding error causes pool to not have enough SUSHIs.