Fix a warning emerging from a testsuite in GTest on newer versions of Clang. #4605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fruffy
changed the title
fruffy
changed the title
vlstill
approved these changes
Apr 9, 2024
lib/gc.cpp
Outdated
| // This error is possible when compiling with clang and including "mm_malloc.h" after the definition | ||
| // of posix_memalign. This can easily happen in unity builds. | ||
| #if defined(__clang__) | ||
| #include <mm_malloc.h> |
There was a problem hiding this comment.
Is this header clang-specific?
There was a problem hiding this comment.
Actually, this is what I am using to fix build failures (#4595). Shouldn't be in this PR.
fruffy
force-pushed
the
fruffy/gtest_warning
branch
from
e36cc46 to
3816c1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: google/googletest#2271 (comment)