Fix init_client for ts and lidar mode bug (ouster-lidar#438)

Remove stray std prefix changing ts and lidar modes to numeral strings Addresses ouster-lidar#437
p5cao · Mar 29, 2023 · 7abf63d · 7abf63d
1 parent 0d44b6b
commit 7abf63d
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 7 deletions.
diff --git a/CHANGELOG.rst b/CHANGELOG.rst
@@ -2,6 +2,15 @@
 Changelog
 =========
 
+
+[20220927]
+==========
+
+ouster_client
+--------------
+* fix a bug in longform init_client which was not setting timestamp_mode and lidar_mode correctly
+
+
 [20220826]
 ==========
 
@@ -43,7 +52,8 @@ ouster_ros
 * drop FW 1.13 compatibility for sensors and recorded bags
 * remove setting of EIGEN_MAX_ALIGN_BYTES
 * add two new ros services /ouster/get_config and /ouster/set_config (experimental)
-* Add new timestamp_mode TIME_FROM_ROS_TIME
+* add new timestamp_mode TIME_FROM_ROS_TIME
+* declare PCL_NO_PRECOMPILE ahead of all PCL library includes
 
 
 [20220608]

diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -7,10 +7,10 @@ include(DefaultBuildType)
 include(VcpkgEnv)
 
 # ==== Project Name ====
-project(ouster_example VERSION 20220826)
+project(ouster_example VERSION 20220927)
 
 # generate version header
-set(OusterSDK_VERSION_STRING 0.5.1)
+set(OusterSDK_VERSION_STRING 0.5.2)
 include(VersionGen)
 
 # ==== Options ====

diff --git a/examples/client_example.cpp b/examples/client_example.cpp
@@ -9,8 +9,8 @@
 #include <iostream>
 #include <vector>
 
-#include "ouster/impl/build.h"
 #include "ouster/client.h"
+#include "ouster/impl/build.h"
 #include "ouster/lidar_scan.h"
 #include "ouster/types.h"
 

diff --git a/ouster_client/src/client.cpp b/ouster_client/src/client.cpp
@@ -300,12 +300,11 @@ std::shared_ptr<client> init_client(const std::string& hostname,
 
         // if specified (not UNSPEC), set the lidar and timestamp modes
         if (mode) {
-            sensor_http->set_config_param("lidar_mode", std::to_string(mode));
+            sensor_http->set_config_param("lidar_mode", to_string(mode));
         }
 
         if (ts_mode) {
-            sensor_http->set_config_param("timestamp_mode",
-                                          std::to_string(ts_mode));
+            sensor_http->set_config_param("timestamp_mode", to_string(ts_mode));
         }
 
         // wake up from STANDBY, if necessary