no-unsafe-any: Allow declare global {} (palantir#2839)

pablonete · May 31, 2017 · 5251926 · 5251926
1 parent 9f6588e
commit 5251926
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/src/rules/noUnsafeAnyRule.ts b/src/rules/noUnsafeAnyRule.ts
@@ -180,6 +180,13 @@ function walk(ctx: Lint.WalkContext<void>, checker: ts.TypeChecker): void {
                 break;
             }
 
+            case ts.SyntaxKind.ModuleDeclaration: {
+                // In `declare global { ... }`, don't mark `global` as unsafe any.
+                const { body } = node as ts.ModuleDeclaration;
+                if (body !== undefined) { cb(body); }
+                return;
+            }
+
             default:
                 if (!(isExpression(node) && check())) {
                     return ts.forEachChild(node, cb);

diff --git a/test/rules/no-unsafe-any/test.ts.lint b/test/rules/no-unsafe-any/test.ts.lint
@@ -179,4 +179,6 @@ switch (x.y) {
         break;
 }
 
+declare global {}
+
 [0]: Unsafe use of expression of type 'any'.
-Original file line number
+Diff line change
@@ Expand Up / @@ -179,4 +179,6 @@ switch (x.y) { @@
             break;
     }
+    declare global {}
     [0]: Unsafe use of expression of type 'any'.