Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to python 3.10 #247

Merged
merged 3 commits into from
Sep 24, 2024
Merged

Update to python 3.10 #247

merged 3 commits into from
Sep 24, 2024

Conversation

corviday
Copy link
Contributor

Switches to a newer version of the geospatial-python docker to fix a couple issues with the build. The new docker has ubuntu 22.04 (was previously ubuntu 18.04), gdal 3.4 (was previously 2.3.1), and python 3.10 (was previously 3.8).

A couple updates to imports to bring the code into line with python 3.10.

Demo of SCIP with this backend.

resolves #233
resolves #243

Copy link
Contributor

@QSparks QSparks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tests are passing, with 9 skipped tests and some deprecation warnings.
I played around with the demo and didn't find anything broken.

With things stabilized, I'd like to investigate whether the P2A-CEB can be brought up to speed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great to see this included!

@corviday
Copy link
Contributor Author

@Nospamas noticed the backend was still throwing some 500s, but it looks like those are in cases where the front end is failing to supply all necessary parameters. Backend may need some error handling, but that is outside the scope of this PR.

@corviday
Copy link
Contributor Author

Following @QSparks 's suggestion, updated the dev instance of plan2adapt to make sure it worked with this backend; it does.

Was unable to do a similar test on the dev climate explorer.

@corviday corviday merged commit 27bf9e6 into master Sep 24, 2024
4 checks passed
@corviday corviday deleted the python310 branch September 25, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

numpy build error sqlalchemy error
2 participants