Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix the docs to correctly represent the config as milliseconds #717

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

pahnin
Copy link
Contributor

@pahnin pahnin commented Aug 30, 2024

  • current docs are incorrect because it should be either 15s or 15000
  • postgres suggests to use milliseconds format in postgres docs, since we just carry forward this value to DB server it just confuses people on what to use

@pahnin pahnin requested review from mefellows and Ilia August 30, 2024 06:08
@mefellows
Copy link
Member

mefellows commented Aug 30, 2024

Seems reasonable to me. I'm still confused how 15s works though if it is supposed to accept millis!

@pahnin
Copy link
Contributor Author

pahnin commented Aug 30, 2024

@pahnin pahnin merged commit 70359c1 into master Aug 30, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants