Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

automatically add publish task and dependency #6

Merged
merged 2 commits into from
May 31, 2018
Merged

automatically add publish task and dependency #6

merged 2 commits into from
May 31, 2018

Conversation

ferozco
Copy link
Contributor

@ferozco ferozco commented May 31, 2018

Fixes issue where typescript consumers would have to manually add a publish task. ex: palantir/conjure#6

@ferozco ferozco requested review from iamdanfox and qinfchen May 31, 2018 15:55
@ferozco ferozco mentioned this pull request May 31, 2018
Merged
ferozco
ferozco commented May 31, 2018
View reviewed changes
.circleci/config.yml
@@ -7,6 +7,7 @@ jobs:
build:
docker:
- image: circleci/openjdk:8u171-jdk-node-browsers
resource_class: xlarge
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢

@iamdanfox iamdanfox merged commit 132a176 into develop May 31, 2018
@iamdanfox iamdanfox deleted the fo/auto-ts-publish branch May 31, 2018 16:12
@pkoenig10 pkoenig10 mentioned this pull request Sep 25, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamdanfox iamdanfox iamdanfox approved these changes

@qinfchen qinfchen Awaiting requested review from qinfchen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ferozco @iamdanfox