Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow disabling version banner #123

Merged
merged 2 commits into from
Oct 24, 2024
Merged

allow disabling version banner #123

merged 2 commits into from
Oct 24, 2024

Conversation

davidism
Copy link
Member

version_banner = False can be set to disable including the version banner JavaScript. It will also be disabled on Read the Docs when building stable or PRs. The stable branch is becoming the default, there's no need to make PyPI requests for that version since we know it's the canonical one.

The banner also works if no <link rel=canonical tag is present. The version is only text and not a link in that case.

@davidism davidism merged commit e02fc95 into main Oct 24, 2024
2 checks passed
@davidism davidism deleted the banner branch October 24, 2024 17:41
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant