schemas: better serialization and error handling

Signed-off-by: Pamfilos Fokianos <[email protected]>

cap/modules/schemas/models.py

@@ -247,7 +247,7 @@ def get_all_versions(cls, name):
             .filter_by(name=name) \
             .order_by(cls.major.desc(),
                       cls.minor.desc(),
-                      cls.patch.desc())
+                      cls.patch.desc()).all()
         if schemas:
             return schemas
         else:

cap/modules/schemas/views.py

@@ -58,14 +58,11 @@ def get_all_versions(name=None):
     if name:
         try:
             schemas = Schema.get_all_versions(name)
-            latest = schemas.first()
-        except JSONSchemaNotFound:
+            latest = schemas[0]
+        except (JSONSchemaNotFound, IndexError):
             abort(404)
-        serialized_versions = [
-            link_serializer.dump(schema).data
-            for schema in schemas]
         response = {
-            'versions': serialized_versions,
+            'versions': link_serializer.dump(schemas, many=True).data,
             'latest': link_serializer.dump(latest).data
         }
     return jsonify(response)

tests/integration/test_schemas_views.py

@@ -462,6 +462,11 @@ def test_get_all_version_of_schema(
         ]
     }
 
+    resp = client.get(
+        '/jsonschemas/wrong_schema/versions/', headers=auth_headers_for_user(cms_user))
+
+    assert resp.status_code == 404
+
 
 def test_get_only_latest_version_of_schemas(
         client, db, users, auth_headers_for_user):