Read existing banner #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use same whitespace style throughout and fix some indents. - change from minetest. to core. namespace.
- unused arguments - shaddowed vars - var redeclarations - some whitespace involved in above lines
save some lines and some extra method calls.
tabs -> spaces
...that slipped through the cracks on previous whitespace edit
or use the faster repeat-until-loop
fixes #5 transformation history was shared by all users and kept growing as it was never truely reset. Every time a user used a banner a white background was dumped on top of the stack making it possible to crash the server through an overflow to core.serialize() function.
also changed banners.max_transformations to banners.max_undo_levels and lowered the value substantially.
since it isn't updating everything, only the preview and the inventory item
to reflect the currently selected colour.
even if only "" it exists and there isn't an error. not adding "" or texture string, causes a non critical error.
only used once and is easy enough to have inline
player could have timed-out and thus lost their history. It isn't crucial to remove their history, so let's give them this feature.
unfortunately the git diff is a bit messy on this one. Nothing changed with: - banners.Banner - banners.Banner:new - banners.Banner:push_transform - banners.Banner:pop_transform content of banners.Banner:get_transform_string was moved to banners.transform_table_to_string with very few changes
allows us to add more features such as: - clean existing banners to slim down data - read transforms from items in inventory -> allow players to change existing patterns without having to start from scratch.
fixes #7 provides a work-around for the engine problem with entities.
… into readExistingBanner
SwissalpS
force-pushed
the
readExistingBanner
branch
from
942bdcd to
1043ea5
Compare
SwissalpS
force-pushed
the
readExistingBanner
branch
from
1043ea5 to
088f94b
Compare
|
closing in favor of #9 which includes all these changes too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
expands on #6
adds:
fixes #7
(by offering a workaround and not crashing when either situation occurs)