Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ZWO camera bandwidthoverload arg #1071

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Add ZWO camera bandwidthoverload arg #1071

wants to merge 1 commit into from

Conversation

danjampro
Copy link
Collaborator

  • Huntsman ZWO cameras are suffering from USB timeout issues
  • Possible solution is to modify the BANDWIDTHOVERLOAD control value
  • This PR adds an argument to the ZWO camera class to allow this to be easily set from config

@danjampro danjampro requested review from wtgee and AnthonyHorton and removed request for wtgee January 27, 2021 03:47
@danjampro danjampro mentioned this pull request Jan 27, 2021
Open
Physarah
Physarah approved these changes Jan 27, 2021
View reviewed changes
Copy link

@Physarah Physarah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@codecov
Copy link

codecov bot commented Jan 27, 2021

Codecov Report

Merging #1071 (08b330c) into develop (cb4d26e) will increase coverage by 0.30%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1071      +/-   ##
===========================================
+ Coverage    84.76%   85.07%   +0.30%     
===========================================
  Files           77       78       +1     
  Lines         6531     6598      +67     
  Branches       560      560              
===========================================
+ Hits          5536     5613      +77     
+ Misses         836      827       -9     
+ Partials       159      158       -1
Impacted Files Coverage Δ
tests/test_mount.py 100.00% <0.00%> (ø)
src/panoptes/pocs/camera/camera.py 83.44% <0.00%> (+0.46%) ⬆️
src/panoptes/pocs/focuser/focuser.py 76.24% <0.00%> (+1.91%) ⬆️
src/panoptes/pocs/dome/astrohaven.py 80.55% <0.00%> (+2.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb4d26e...08b330c. Read the comment docs.

@Physarah
Copy link

Sorry Dan I don't have write access ;P

@wtgee
Copy link
Member

wtgee commented Jan 27, 2021

@Physarah Is a property needed? Why not the solution presented in your description in AstroHuntsman/huntsman-pocs#330?

@danjampro
Copy link
Collaborator Author

@Physarah Is a property needed? Why not the solution presented in your description in AstroHuntsman/huntsman-pocs#330?

@wtgee The problem is that these errors are random. We'll have to run many exposures during normal pocs operation to see if this makes a difference. This method will allow us to easily configure e.g. half the cameras on 100% and the other half on a lower value.

@wtgee wtgee mentioned this pull request Jan 28, 2021
Merged
wtgee added a commit that referenced this pull request Jan 31, 2021
@wtgee
Docker and Cloudbuild fixes (#1074)
0c220fd 
Following changes in `panoptes-utils`, this cleans up and simplifies the Docker services.

## Description

* **Breaking change** Python 3.8
* **Breaking change** Default service install does not include ``focuser`` dependencies.
* **Breaking change** Default Docker command is a ``ipython`` console with the simulators loaded.
* **Breaking change** Docker image only contains limited set of files.
* **Breaking change** Directories inside the service image have been simplified for easier mapping onto desired targets on the host. The main top-level directory (i.e. ``$PANDIR``) is now ``/POCS`` with other folders nested underneath.
* **Breaking change** Removing ``peas`` scripts.
* Simple example script for creating a ``POCS`` instance with all simulators.
* Using ``threading.excepthook`` to log errors in camera exposure threads. Addresses some of #1047.
* Updated install script (includes ZSH again).
* Pointing state is skipped if `num_pointing_images==0`.
* Images use ``gcr.io/panoptes-exp/panoptes-utils`` as base.
* Docker files are all contained within ``docker`` folder.
* Docker image has tycho2 10-19 index files for plate-solving.
* Docker services (``config-server`` and ``pocs-control``) are started in ``global`` mode so there can be only one.
* Config changed to run with simulators out of the box.
* Removing old scripts and config files.
* Simplify testing service by removing ``tests/env`` file.
* The default ``radius`` for solving images is 15°. 

## Related Issue
Needed by #1071, #1072
@danjampro
Copy link
Collaborator Author

@wtgee we discussed this and agreed a property is appropriate. Can we merge?

@danjampro danjampro mentioned this pull request Feb 10, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Physarah Physarah Physarah approved these changes

@AnthonyHorton AnthonyHorton Awaiting requested review from AnthonyHorton

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danjampro @Physarah @wtgee