Add node style setter #78
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pantoniou
reviewed
Apr 25, 2023
| if (fyn->style == FYNS_ALIAS) | ||
| return; | ||
|
|
||
| fyn->style = style; |
There was a problem hiding this comment.
I wish it was so simple.
The problem is that for scalars it is quite possible to set a style that is illegal.
For instance change a double quoted scalar node's style to plain is illegal if the scalar has \0 for example.
So for the setter to work it must run a check of what are the permissible styles, and allow the setting if permitted.
There was a problem hiding this comment.
I would like to make at least unchecked dangrous version like fy_node_set_style_unchecked, because currently we don't have public interface to change style at all. It is a problem for outputting some nodes in somehow beautified way
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.