Skip to content

Commit

Permalink
Rename lodash.custom.min.js to lodash.js so our JS code hinting finds…
Browse files Browse the repository at this point in the history
… it. Remove the special path for it so it's more consistent with other require paths that have to be relative to src.
  • Loading branch information
Narciso Jaramillo committed Oct 28, 2013
1 parent 3ceb511 commit 010bc62
Show file tree
Hide file tree
Showing 29 changed files with 30 additions and 32 deletions.
5 changes: 2 additions & 3 deletions src/brackets.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,7 @@
require.config({
paths: {
"text" : "thirdparty/text/text",
"i18n" : "thirdparty/i18n/i18n",
"lodash" : "thirdparty/lodash.custom.min"
"i18n" : "thirdparty/i18n/i18n"
},
// Use custom brackets property until CEF sets the correct navigator.language
// NOTE: When we change to navigator.language here, we also should change to
Expand Down Expand Up @@ -100,7 +99,7 @@ define(function (require, exports, module) {
ColorUtils = require("utils/ColorUtils"),
CodeInspection = require("language/CodeInspection"),
NativeApp = require("utils/NativeApp"),
_ = require("lodash");
_ = require("thirdparty/lodash");

// Load modules that self-register and just need to get included in the main project
require("command/DefaultMenus");
Expand Down
2 changes: 1 addition & 1 deletion src/command/Menus.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
define(function (require, exports, module) {
"use strict";

var _ = require("lodash");
var _ = require("thirdparty/lodash");

// Load dependent modules
var Global = require("utils/Global"),
Expand Down
2 changes: 1 addition & 1 deletion src/document/DocumentManager.js
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@
define(function (require, exports, module) {
"use strict";

var _ = require("lodash");
var _ = require("thirdparty/lodash");

var DocumentModule = require("document/Document"),
NativeFileSystem = require("file/NativeFileSystem").NativeFileSystem,
Expand Down
2 changes: 1 addition & 1 deletion src/editor/CSSInlineEditor.js
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ define(function (require, exports, module) {
MultiRangeInlineEditor = require("editor/MultiRangeInlineEditor"),
PopUpManager = require("widgets/PopUpManager"),
Strings = require("strings"),
_ = require("lodash");
_ = require("thirdparty/lodash");

var StylesheetsMenuTemplate = require("text!htmlContent/stylesheets-menu.html");

Expand Down
2 changes: 1 addition & 1 deletion src/editor/MultiRangeInlineEditor.js
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
define(function (require, exports, module) {
"use strict";

var _ = require("lodash");
var _ = require("thirdparty/lodash");

// Load dependent modules
var TextRange = require("document/TextRange").TextRange,
Expand Down
2 changes: 1 addition & 1 deletion src/extensibility/ExtensionManagerViewModel.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
define(function (require, exports, module) {
"use strict";

var _ = require("lodash");
var _ = require("thirdparty/lodash");

var ExtensionManager = require("extensibility/ExtensionManager"),
Package = require("extensibility/Package"),
Expand Down
2 changes: 1 addition & 1 deletion src/extensions/default/DebugCommands/main.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
define(function (require, exports, module) {
"use strict";

var _ = brackets.getModule("lodash");
var _ = brackets.getModule("thirdparty/lodash");

var Commands = brackets.getModule("command/Commands"),
CommandManager = brackets.getModule("command/CommandManager"),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
define(function (require, exports, module) {
"use strict";

var _ = brackets.getModule("lodash");
var _ = brackets.getModule("thirdparty/lodash");

var Commands = brackets.getModule("command/Commands"),
CommandManager = brackets.getModule("command/CommandManager"),
Expand Down
2 changes: 1 addition & 1 deletion src/extensions/default/JavaScriptCodeHints/ScopeManager.js
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
define(function (require, exports, module) {
"use strict";

var _ = brackets.getModule("lodash");
var _ = brackets.getModule("thirdparty/lodash");

var DocumentManager = brackets.getModule("document/DocumentManager"),
LanguageManager = brackets.getModule("language/LanguageManager"),
Expand Down
2 changes: 1 addition & 1 deletion src/extensions/default/JavaScriptCodeHints/main.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
define(function (require, exports, module) {
"use strict";

var _ = brackets.getModule("lodash");
var _ = brackets.getModule("thirdparty/lodash");

var CodeHintManager = brackets.getModule("editor/CodeHintManager"),
EditorManager = brackets.getModule("editor/EditorManager"),
Expand Down
2 changes: 1 addition & 1 deletion src/language/JSUtils.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
define(function (require, exports, module) {
"use strict";

var _ = require("lodash");
var _ = require("thirdparty/lodash");

// Load brackets modules
var Async = require("utils/Async"),
Expand Down
2 changes: 1 addition & 1 deletion src/preferences/PreferenceStorage.js
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
define(function (require, exports, module) {
"use strict";

var _ = require("lodash");
var _ = require("thirdparty/lodash");

var PreferencesManager = require("preferences/PreferencesManager");

Expand Down
2 changes: 1 addition & 1 deletion src/preferences/PreferencesManager.js
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
define(function (require, exports, module) {
"use strict";

var _ = require("lodash");
var _ = require("thirdparty/lodash");

var PreferenceStorage = require("preferences/PreferenceStorage").PreferenceStorage,
FileUtils = require("file/FileUtils"),
Expand Down
2 changes: 1 addition & 1 deletion src/project/FileIndexManager.js
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
define(function (require, exports, module) {
"use strict";

var _ = require("lodash");
var _ = require("thirdparty/lodash");

var PerfUtils = require("utils/PerfUtils"),
ProjectManager = require("project/ProjectManager"),
Expand Down
2 changes: 1 addition & 1 deletion src/project/ProjectManager.js
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ define(function (require, exports, module) {
// Load dependent non-module scripts
require("thirdparty/jstree_pre1.0_fix_1/jquery.jstree");

var _ = require("lodash");
var _ = require("thirdparty/lodash");

// Load dependent modules
var AppInit = require("utils/AppInit"),
Expand Down
2 changes: 1 addition & 1 deletion src/project/WorkingSetView.js
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
define(function (require, exports, module) {
"use strict";

var _ = require("lodash");
var _ = require("thirdparty/lodash");

// Load dependent modules
var DocumentManager = require("document/DocumentManager"),
Expand Down
2 changes: 1 addition & 1 deletion src/search/FindInFiles.js
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
define(function (require, exports, module) {
"use strict";

var _ = require("lodash");
var _ = require("thirdparty/lodash");

var Async = require("utils/Async"),
Resizer = require("utils/Resizer"),
Expand Down
2 changes: 1 addition & 1 deletion src/search/ScrollTrackMarkers.js
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
define(function (require, exports, module) {
"use strict";

var _ = require("lodash");
var _ = require("thirdparty/lodash");

var Editor = require("editor/Editor"),
EditorManager = require("editor/EditorManager");
Expand Down
2 changes: 1 addition & 1 deletion src/strings.js
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
define(function (require, exports, module) {
"use strict";

var _ = require("lodash");
var _ = require("thirdparty/lodash");

var strings = require("i18n!nls/strings"),
urls = require("i18n!nls/urls"),
Expand Down
File renamed without changes.
2 changes: 1 addition & 1 deletion src/utils/CollectionUtils.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
define(function (require, exports, module) {
"use strict";

var _ = require("lodash");
var _ = require("thirdparty/lodash");

/**
* Returns the first index in 'array' for which isMatch() returns true, or -1 if none
Expand Down
2 changes: 1 addition & 1 deletion src/utils/PerfUtils.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
define(function (require, exports, module) {
"use strict";

var _ = require("lodash");
var _ = require("thirdparty/lodash");

var Global = require("utils/Global");

Expand Down
2 changes: 1 addition & 1 deletion src/utils/StringMatch.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
define(function (require, exports, module) {
"use strict";

var _ = require("lodash");
var _ = require("thirdparty/lodash");

/*
* Performs matching that is useful for QuickOpen and similar searches.
Expand Down
2 changes: 1 addition & 1 deletion src/utils/StringUtils.js
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
define(function (require, exports, module) {
"use strict";

var _ = require("lodash");
var _ = require("thirdparty/lodash");

/**
* Format a string by replacing placeholder symbols with passed in arguments.
Expand Down
2 changes: 1 addition & 1 deletion src/utils/UrlParams.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
define(function (require, exports, module) {
"use strict";

var _ = require("lodash");
var _ = require("thirdparty/lodash");

/**
* Convert between URL querystring and name/value pairs. Decodes and encodes URL parameters.
Expand Down
2 changes: 1 addition & 1 deletion test/BootstrapReporterView.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
define(function (require, exports, module) {
'use strict';

var _ = require("lodash");
var _ = require("thirdparty/lodash");

var UrlParams = require("utils/UrlParams").UrlParams,
SpecRunnerUtils = require("spec/SpecRunnerUtils");
Expand Down
5 changes: 2 additions & 3 deletions test/SpecRunner.js
Original file line number Diff line number Diff line change
Expand Up @@ -32,15 +32,14 @@ require.config({
"perf" : "../test/perf",
"spec" : "../test/spec",
"text" : "thirdparty/text/text",
"i18n" : "thirdparty/i18n/i18n",
"lodash" : "thirdparty/lodash.custom.min"
"i18n" : "thirdparty/i18n/i18n"
}
});

define(function (require, exports, module) {
'use strict';

var _ = require("lodash");
var _ = require("thirdparty/lodash");

// Utility dependency
var AppInit = require("utils/AppInit"),
Expand Down
2 changes: 1 addition & 1 deletion test/spec/ExtensionManager-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ define(function (require, exports, module) {

require("thirdparty/jquery.mockjax.js");

var _ = require("lodash");
var _ = require("thirdparty/lodash");

var ExtensionManager = require("extensibility/ExtensionManager"),
ExtensionManagerView = require("extensibility/ExtensionManagerView").ExtensionManagerView,
Expand Down
2 changes: 1 addition & 1 deletion test/spec/StringMatch-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
define(function (require, exports, module) {
'use strict';

var _ = require("lodash");
var _ = require("thirdparty/lodash");

var StringMatch = require("utils/StringMatch");

Expand Down

0 comments on commit 010bc62

Please sign in to comment.