Enable releasing free hugepages from HugeRegions by default.

PiperOrigin-RevId: 562832763 Change-Id: I50681c974d7bca8ccc9e786356d44436ef155f52
patrickxia · Sep 5, 2023 · 002b8b8 · 002b8b8
1 parent 67924d8
commit 002b8b8
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/tcmalloc/parameters.cc b/tcmalloc/parameters.cc
@@ -128,7 +128,7 @@ ABSL_CONST_INIT std::atomic<bool> Parameters::improved_guarded_sampling_(true);
 ABSL_CONST_INIT std::atomic<bool> Parameters::release_partial_alloc_pages_(
     true);
 ABSL_CONST_INIT std::atomic<bool> Parameters::release_pages_from_huge_region_(
-    false);
+    true);
 ABSL_CONST_INIT std::atomic<int64_t> Parameters::max_total_thread_cache_bytes_(
     kDefaultOverallThreadCacheSize);
 ABSL_CONST_INIT std::atomic<double>

diff --git a/tcmalloc/testing/get_stats_test.cc b/tcmalloc/testing/get_stats_test.cc
@@ -109,7 +109,7 @@ TEST_F(GetStatsTest, Pbtxt) {
   EXPECT_THAT(buf, HasSubstr("tcmalloc_skip_subrelease_long_interval_ns: 0"));
 
   EXPECT_THAT(buf, HasSubstr("tcmalloc_release_partial_alloc_pages: true"));
-  EXPECT_THAT(buf, HasSubstr("tcmalloc_release_pages_from_huge_region: false"));
+  EXPECT_THAT(buf, HasSubstr("tcmalloc_release_pages_from_huge_region: true"));
   EXPECT_THAT(buf, HasSubstr("tcmalloc_resize_cpu_cache_size_classes: true"));
   EXPECT_THAT(buf, ContainsRegex("(tcmalloc_filler_chunks_per_alloc: 8|(16))"));
 
@@ -164,7 +164,7 @@ TEST_F(GetStatsTest, Parameters) {
         buf, HasSubstr(R"(PARAMETER tcmalloc_release_partial_alloc_pages 1)"));
     EXPECT_THAT(
         buf,
-        HasSubstr(R"(PARAMETER tcmalloc_release_pages_from_huge_region 0)"));
+        HasSubstr(R"(PARAMETER tcmalloc_release_pages_from_huge_region 1)"));
     EXPECT_THAT(
         buf,
         HasSubstr(R"(PARAMETER tcmalloc_resize_cpu_cache_size_classes 1)"));