Setting both etag and modified-since fixes some

eg mysql sources are 400MB and the cache hit wasn't working even though they send an etag. Setting the if modified since in addition to the etag fixed that. Now they return a 304.
paulickingshotts · Apr 13, 2023 · 0e5d935 · 0e5d935
1 parent 6f6c26f
commit 0e5d935
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/README.md b/README.md
@@ -16,7 +16,7 @@
 </p>
 
 
-# tea/cli 0.26.4
+# tea/cli 0.27.0
 
 `tea` puts the whole open source ecosystem at your fingertips:
 

diff --git a/src/hooks/useDownload.ts b/src/hooks/useDownload.ts
@@ -40,7 +40,10 @@ async function internal<T>({ src, headers, logger, dst }: DownloadOptions): Prom
     headers ??= {}
     if (etag_entry.isFile()) {
       headers["If-None-Match"] = await etag_entry.read()
-    } else if (mtime_entry.isFile()) {
+    }
+    // sending both if we have them is ChatGPT recommended
+    // also this fixes getting the mysql.com sources, otherwise it redownloads 400MB every time!
+    if (mtime_entry.isFile()) {
       headers["If-Modified-Since"] = await mtime_entry.read()
     }
     logger.replace(teal('querying'))
-Original file line number
+Diff line change
@@ Expand Up / @@ -16,7 +16,7 @@ @@
     </p>
-    # tea/cli 0.26.4
+    # tea/cli 0.27.0
     `tea` puts the whole open source ecosystem at your fingertips:
@@ Expand Down @@