Skip to content

Commit

Permalink
Remove unnecessary entry-point closurization. (flutter#7827)
Browse files Browse the repository at this point in the history
  • Loading branch information
sjindel-google authored Feb 18, 2019
1 parent 62d05c2 commit 3a1b9b3
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 16 deletions.
2 changes: 1 addition & 1 deletion lib/stub_ui/natives.dart
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ Future<developer.ServiceExtensionResponse> _scheduleFrame(
}));
}

@pragma('vm:entry-point')
@pragma('vm:entry-point', 'call')
void _setupHooks() { // ignore: unused_element
assert(() {
// In debug mode, register the schedule frame extension.
Expand Down
24 changes: 12 additions & 12 deletions lib/ui/hooks.dart
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ dynamic _decodeJSON(String message) {
return message != null ? json.decode(message) : null;
}

@pragma('vm:entry-point')
@pragma('vm:entry-point', 'call')
// ignore: unused_element
void _updateWindowMetrics(double devicePixelRatio,
double width,
Expand Down Expand Up @@ -54,11 +54,11 @@ String _localeClosure() {
return window.locale.toString();
}

@pragma('vm:entry-point')
@pragma('vm:entry-point', 'call')
// ignore: unused_element
_LocaleClosure _getLocaleClosure() => _localeClosure;

@pragma('vm:entry-point')
@pragma('vm:entry-point', 'call')
// ignore: unused_element
void _updateLocales(List<String> locales) {
const int stringsPerLocale = 4;
Expand All @@ -77,7 +77,7 @@ void _updateLocales(List<String> locales) {
_invoke(window.onLocaleChanged, window._onLocaleChangedZone);
}

@pragma('vm:entry-point')
@pragma('vm:entry-point', 'call')
// ignore: unused_element
void _updateUserSettingsData(String jsonData) {
final Map<String, dynamic> data = json.decode(jsonData);
Expand All @@ -103,14 +103,14 @@ void _updatePlatformBrightness(String brightnessName) {
_invoke(window.onPlatformBrightnessChanged, window._onPlatformBrightnessChangedZone);
}

@pragma('vm:entry-point')
@pragma('vm:entry-point', 'call')
// ignore: unused_element
void _updateSemanticsEnabled(bool enabled) {
window._semanticsEnabled = enabled;
_invoke(window.onSemanticsEnabledChanged, window._onSemanticsEnabledChangedZone);
}

@pragma('vm:entry-point')
@pragma('vm:entry-point', 'call')
// ignore: unused_element
void _updateAccessibilityFeatures(int values) {
final AccessibilityFeatures newFeatures = new AccessibilityFeatures._(values);
Expand All @@ -120,7 +120,7 @@ void _updateAccessibilityFeatures(int values) {
_invoke(window.onAccessibilityFeaturesChanged, window._onAccessibilityFlagsChangedZone);
}

@pragma('vm:entry-point')
@pragma('vm:entry-point', 'call')
void _dispatchPlatformMessage(String name, ByteData data, int responseId) {
if (window.onPlatformMessage != null) {
_invoke3<String, ByteData, PlatformMessageResponseCallback>(
Expand All @@ -137,14 +137,14 @@ void _dispatchPlatformMessage(String name, ByteData data, int responseId) {
}
}

@pragma('vm:entry-point')
@pragma('vm:entry-point', 'call')
// ignore: unused_element
void _dispatchPointerDataPacket(ByteData packet) {
if (window.onPointerDataPacket != null)
_invoke1<PointerDataPacket>(window.onPointerDataPacket, window._onPointerDataPacketZone, _unpackPointerDataPacket(packet));
}

@pragma('vm:entry-point')
@pragma('vm:entry-point', 'call')
// ignore: unused_element
void _dispatchSemanticsAction(int id, int action, ByteData args) {
_invoke3<int, SemanticsAction, ByteData>(
Expand All @@ -156,13 +156,13 @@ void _dispatchSemanticsAction(int id, int action, ByteData args) {
);
}

@pragma('vm:entry-point')
@pragma('vm:entry-point', 'call')
// ignore: unused_element
void _beginFrame(int microseconds) {
_invoke1<Duration>(window.onBeginFrame, window._onBeginFrameZone, new Duration(microseconds: microseconds));
}

@pragma('vm:entry-point')
@pragma('vm:entry-point', 'call')
// ignore: unused_element
void _drawFrame() {
_invoke(window.onDrawFrame, window._onDrawFrameZone);
Expand All @@ -173,7 +173,7 @@ typedef _UnaryFunction(Null args);
// ignore: always_declare_return_types, prefer_generic_function_type_aliases
typedef _BinaryFunction(Null args, Null message);

@pragma('vm:entry-point')
@pragma('vm:entry-point', 'call')
// ignore: unused_element
void _runMainZoned(Function startMainIsolateFunction, Function userMainFunction) {
startMainIsolateFunction((){
Expand Down
6 changes: 3 additions & 3 deletions lib/ui/natives.dart
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ Future<developer.ServiceExtensionResponse> _scheduleFrame(
}));
}

@pragma('vm:entry-point')
@pragma('vm:entry-point', 'call')
void _setupHooks() { // ignore: unused_element
assert(() {
// In debug mode, register the schedule frame extension.
Expand Down Expand Up @@ -71,7 +71,7 @@ Function _getCallbackFromHandle(int handle) native 'GetCallbackFromHandle';
// Required for gen_snapshot to work correctly.
int _isolateId; // ignore: unused_element

@pragma('vm:entry-point')
@pragma('vm:entry-point', 'call')
Function _getPrintClosure() => _print; // ignore: unused_element
@pragma('vm:entry-point')
@pragma('vm:entry-point', 'call')
Function _getScheduleMicrotaskClosure() => _scheduleMicrotask; // ignore: unused_element

0 comments on commit 3a1b9b3

Please sign in to comment.