Skip to content

Commit

Permalink
Bug 1346161 - Remove HANDLE_UNLOAD_MS and HANDLE_BEFOREUNLOAD_MS tele…
Browse files Browse the repository at this point in the history
…metry probes. r=smaug

MozReview-Commit-ID: 91WAGDKAAMu
  • Loading branch information
kanru committed Mar 13, 2017
1 parent 6b7f007 commit 43776b9
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 27 deletions.
12 changes: 3 additions & 9 deletions layout/base/nsDocumentViewer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1187,11 +1187,8 @@ nsDocumentViewer::PermitUnloadInternal(bool *aShouldPrompt,
nsIDocument::PageUnloadingEventTimeStamp timestamp(mDocument);

mInPermitUnload = true;
{
Telemetry::AutoTimer<Telemetry::HANDLE_BEFOREUNLOAD_MS> telemetryTimer;
EventDispatcher::DispatchDOMEvent(window, nullptr, event, mPresContext,
nullptr);
}
EventDispatcher::DispatchDOMEvent(window, nullptr, event, mPresContext,
nullptr);
mInPermitUnload = false;
}

Expand Down Expand Up @@ -1378,10 +1375,7 @@ nsDocumentViewer::PageHide(bool aIsUnload)

nsIDocument::PageUnloadingEventTimeStamp timestamp(mDocument);

{
Telemetry::AutoTimer<Telemetry::HANDLE_UNLOAD_MS> telemetryTimer;
EventDispatcher::Dispatch(window, mPresContext, &event, nullptr, &status);
}
EventDispatcher::Dispatch(window, mPresContext, &event, nullptr, &status);
}

#ifdef MOZ_XUL
Expand Down
18 changes: 0 additions & 18 deletions toolkit/components/telemetry/Histograms.json
Original file line number Diff line number Diff line change
Expand Up @@ -10912,24 +10912,6 @@
"n_buckets": 30,
"description": "Time in MS that content is narrated in 10 second increments up to 5 minutes"
},
"HANDLE_UNLOAD_MS": {
"alert_emails": ["[email protected]"],
"expires_in_version": "55",
"kind": "exponential",
"high": 10000,
"n_buckets": 50,
"bug_numbers": [1301346],
"description": "The time spent handling unload event in milliseconds. It measures all documents and subframes separately. If there are multiple handlers for the unload event in a document, this will record a single value across all handlers in the document."
},
"HANDLE_BEFOREUNLOAD_MS": {
"alert_emails": ["[email protected]"],
"expires_in_version": "55",
"kind": "exponential",
"high": 10000,
"n_buckets": 50,
"bug_numbers": [1301346],
"description": "The time spent handling beforeunload event in milliseconds. It measures all documents and subframes separately. If there are multiple handlers for the unload event in a document, this will record a single value across all handlers in the document."
},
"TABCHILD_PAINT_TIME": {
"alert_emails": ["[email protected]"],
"bug_numbers": [1313686],
Expand Down

0 comments on commit 43776b9

Please sign in to comment.