fix: chevron and clear icons overalapping in address input

[kushagrasarathe]

fixes TASK-9064

Summary by CodeRabbit

• New Features
  • Input fields now offer optional labeling, enhancing flexibility.
• Refactor
  • Reorganized the layout for cleaner alignment and streamlined control grouping.
  • Improved the display of validation and loading feedback for a more responsive experience.
• Style
  • Updated dynamic styling ensures a consistent and refined visual appearance when supplementary information is present.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
peanut-ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 17, 2025 6:58pm

[coderabbitai]

Walkthrough

The pull request updates the ValidatedInput component by making the label prop optional. It adds a new import for a Loading component while refactoring the layout to use a flex container. The styling is updated by replacing the fixed border class with dynamic class handling using twMerge based on the presence of infoText. Additionally, the conditional rendering logic for validation and loading indicators has been simplified and reorganized.

Changes

File Path	Change Summary
src/components/.../ValidatedInput/index.tsx	- Updated label: string to label?: string in props - Added import for Loading - Replaced fixed classes with twMerge for dynamic styling - Changed outer container layout from relative to flex - Simplified validation/loading state rendering logic

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant ValidatedInput
    participant Loading

    User->>+ValidatedInput: Enters data/Interacts
    ValidatedInput->>ValidatedInput: Evaluate props and state (isValidating, infoText)
    alt isValidating is true
        ValidatedInput->>Loading: Render loading indicator with dynamic opacity
    else
        ValidatedInput->>ValidatedInput: Apply dynamic classes using twMerge
    end
    ValidatedInput-->>User: Render updated input component layout

Loading

Possibly related PRs

• [TASK-6944] fix: disable autocorrect on address input #532: Introduces similar modifications in input behavior by adding attributes like autoCorrect, autoCapitalize, and autoComplete, aligning with the updates made in the ValidatedInput component.

Suggested reviewers

• Hugo0

Poem

I'm a happy bunny, coding all day,
Hopping through changes, making bugs stray.
Optional labels now lead the way,
With loading signs bright as the sun's ray.
In flex layouts we frolic, come join the play! 🐇🥕
Code carrots crunch in a computational ballet.
Celebrate these changes, hip hip hooray!

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[notion-workspace]

Deploy Chevron fix to Peanut.to

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/components/Global/ValidatedInput/index.tsx (1)

113-118: Simplify the boolean condition.

The double negation in the padding condition can be simplified.

-                        !!infoText ? 'pl-8' : 'pl-4'
+                        infoText ? 'pl-8' : 'pl-4'

🧰 Tools

🪛 Biome (1.9.4)

[error] 117-117: Avoid redundant double-negation.

It is not necessary to use double-negation when a value will already be coerced to a boolean.
Unsafe fix: Remove redundant double-negation

(lint/complexity/noExtraBooleanCast)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 41019cb and 24e1e09.

📒 Files selected for processing (1)

• src/components/Global/ValidatedInput/index.tsx (4 hunks)

🧰 Additional context used

🪛 Biome (1.9.4)

src/components/Global/ValidatedInput/index.tsx

[error] 117-117: Avoid redundant double-negation.

It is not necessary to use double-negation when a value will already be coerced to a boolean.
Unsafe fix: Remove redundant double-negation

(lint/complexity/noExtraBooleanCast)

🔇 Additional comments (5)

src/components/Global/ValidatedInput/index.tsx (5)

3-5: LGTM!

The new imports and optional label prop enhance the component's flexibility and maintainability.

Also applies to: 8-8

---

95-99: LGTM!

The flex layout and conditional border styling provide proper visual feedback while maintaining component structure.

---

131-137: LGTM!

The datalist implementation follows HTML standards and React best practices.

---

138-145: LGTM!

The opacity handling improves usability across different devices while maintaining a clean interface.

---

146-162: LGTM!

The implementation successfully fixes the icon overlapping issue while providing clear visual feedback during validation.