Fix wrong result from the best master clock algorithm.

The BMC should never return 'faulty', and I don't know what I was thinking here, so let's just fix it. Signed-off-by: Richard Cochran <[email protected]>
peci1 · Jan 7, 2012 · 807ec32 · 807ec32
1 parent 335100c
commit 807ec32
Showing 1 changed file with 2 additions and 6 deletions.
diff --git a/bmc.c b/bmc.c
@@ -114,12 +114,8 @@ enum port_state bmc_state_decision(struct clock *c, struct port *r)
 	port_best = port_best_foreign(r);
 	ps = port_state(r);
 
-	if (!port_best) {
-		if (PS_LISTENING == ps)
-			return ps;
-		else
-			return PS_FAULTY;
-	}
+	if (!port_best && PS_LISTENING == ps)
+		return ps;
 
 	if (!clock_best)
 		return PS_FAULTY;