Skip to content

Commit

Permalink
ALSA: sh: constify snd_pcm_ops structures
Browse files Browse the repository at this point in the history
snd_pcm_ops are not supposed to change at runtime. All functions
working with snd_pcm_ops provided by <sound/pcm.h> work with
const snd_pcm_ops. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <[email protected]>
Signed-off-by: Takashi Iwai <[email protected]>
  • Loading branch information
ArvindYadavCs authored and tiwai committed Aug 19, 2017
1 parent 3179a3e commit 46a085a
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion sound/sh/aica.c
Original file line number Diff line number Diff line change
Expand Up @@ -436,7 +436,7 @@ static unsigned long snd_aicapcm_pcm_pointer(struct snd_pcm_substream
return readl(AICA_CONTROL_CHANNEL_SAMPLE_NUMBER);
}

static struct snd_pcm_ops snd_aicapcm_playback_ops = {
static const struct snd_pcm_ops snd_aicapcm_playback_ops = {
.open = snd_aicapcm_pcm_open,
.close = snd_aicapcm_pcm_close,
.ioctl = snd_pcm_lib_ioctl,
Expand Down
2 changes: 1 addition & 1 deletion sound/sh/sh_dac_audio.c
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ snd_pcm_uframes_t snd_sh_dac_pcm_pointer(struct snd_pcm_substream *substream)
}

/* pcm ops */
static struct snd_pcm_ops snd_sh_dac_pcm_ops = {
static const struct snd_pcm_ops snd_sh_dac_pcm_ops = {
.open = snd_sh_dac_pcm_open,
.close = snd_sh_dac_pcm_close,
.ioctl = snd_pcm_lib_ioctl,
Expand Down

0 comments on commit 46a085a

Please sign in to comment.