HID: roccat: prevent an out of bounds read in kovaplus_profile_activa…

…ted() We get the "new_profile_index" value from the mouse device when we're handling raw events. Smatch taints it as untrusted data and complains that we need a bounds check. This seems like a reasonable warning otherwise there is a small read beyond the end of the array. Fixes: 0e70f97 ("HID: roccat: Add support for Kova[+] mouse") Signed-off-by: Dan Carpenter <[email protected]> Acked-by: Silvan Jegen <[email protected]> Signed-off-by: Jiri Kosina <[email protected]>
penberg · Jan 23, 2018 · 7ad8148 · 7ad8148
1 parent 7cb4774
commit 7ad8148
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/drivers/hid/hid-roccat-kovaplus.c b/drivers/hid/hid-roccat-kovaplus.c
@@ -37,6 +37,8 @@ static uint kovaplus_convert_event_cpi(uint value)
 static void kovaplus_profile_activated(struct kovaplus_device *kovaplus,
 		uint new_profile_index)
 {
+	if (new_profile_index >= ARRAY_SIZE(kovaplus->profile_settings))
+		return;
 	kovaplus->actual_profile = new_profile_index;
 	kovaplus->actual_cpi = kovaplus->profile_settings[new_profile_index].cpi_startup_level;
 	kovaplus->actual_x_sensitivity = kovaplus->profile_settings[new_profile_index].sensitivity_x;