Skip to content

Commit

Permalink
media: venus: vdec: Fix forgotten mutex unlock in start streaming
Browse files Browse the repository at this point in the history
This fixes the following smatch warning in the error path:

drivers/media/platform/qcom/venus/vdec.c:968 vdec_start_streaming()
 warn: inconsistent returns 'mutex:&inst->lock'.
  Locked on:   line 952
  Unlocked on: line 963
               line 968

by goto mutex unlock.

Signed-off-by: Stanimir Varbanov <[email protected]>
Signed-off-by: Mauro Carvalho Chehab <[email protected]>
  • Loading branch information
Stanimir Varbanov authored and mchehab committed Mar 12, 2020
1 parent eceeea5 commit 808431d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/media/platform/qcom/venus/vdec.c
Original file line number Diff line number Diff line change
Expand Up @@ -949,7 +949,7 @@ static int vdec_start_streaming(struct vb2_queue *q, unsigned int count)

ret = venus_pm_acquire_core(inst);
if (ret)
return ret;
goto error;

if (q->type == V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE)
ret = vdec_start_capture(inst);
Expand Down

0 comments on commit 808431d

Please sign in to comment.