Skip to content

Commit

Permalink
crypto: ecdh - make ecdh_shared_secret unique
Browse files Browse the repository at this point in the history
There is another ecdh_shared_secret in net/bluetooth/ecc.c

Fixes: 3c4b239 ("crypto: ecdh - Add ECDH software support")
Signed-off-by: Stephen Rothwell <[email protected]>
Signed-off-by: Herbert Xu <[email protected]>
  • Loading branch information
sfrothwell authored and herbertx committed Jun 24, 2016
1 parent 5214099 commit 8f44df1
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion crypto/ecc.c
Original file line number Diff line number Diff line change
Expand Up @@ -966,7 +966,7 @@ int ecdh_make_pub_key(unsigned int curve_id, unsigned int ndigits,
return ret;
}

int ecdh_shared_secret(unsigned int curve_id, unsigned int ndigits,
int crypto_ecdh_shared_secret(unsigned int curve_id, unsigned int ndigits,
const u8 *private_key, unsigned int private_key_len,
const u8 *public_key, unsigned int public_key_len,
u8 *secret, unsigned int secret_len)
Expand Down
6 changes: 3 additions & 3 deletions crypto/ecc.h
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ int ecdh_make_pub_key(const unsigned int curve_id, unsigned int ndigits,
u8 *public_key, unsigned int public_key_len);

/**
* ecdh_shared_secret() - Compute a shared secret
* crypto_ecdh_shared_secret() - Compute a shared secret
*
* @curve_id: id representing the curve to use
* @private_key: private key of part A
Expand All @@ -70,13 +70,13 @@ int ecdh_make_pub_key(const unsigned int curve_id, unsigned int ndigits,
* @secret: buffer for storing the calculated shared secret
* @secret_len: length of the secret buffer
*
* Note: It is recommended that you hash the result of ecdh_shared_secret
* Note: It is recommended that you hash the result of crypto_ecdh_shared_secret
* before using it for symmetric encryption or HMAC.
*
* Returns 0 if the shared secret was generated successfully, a negative value
* if an error occurred.
*/
int ecdh_shared_secret(unsigned int curve_id, unsigned int ndigits,
int crypto_ecdh_shared_secret(unsigned int curve_id, unsigned int ndigits,
const u8 *private_key, unsigned int private_key_len,
const u8 *public_key, unsigned int public_key_len,
u8 *secret, unsigned int secret_len);
Expand Down
2 changes: 1 addition & 1 deletion crypto/ecdh.c
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ static int ecdh_compute_value(struct kpp_request *req)
if (copied != 2 * nbytes)
return -EINVAL;

ret = ecdh_shared_secret(ctx->curve_id, ctx->ndigits,
ret = crypto_ecdh_shared_secret(ctx->curve_id, ctx->ndigits,
(const u8 *)ctx->private_key, nbytes,
(const u8 *)ctx->public_key, 2 * nbytes,
(u8 *)ctx->shared_secret, nbytes);
Expand Down

0 comments on commit 8f44df1

Please sign in to comment.