Skip to content

Commit

Permalink
HID: wacom: Correct logical maximum Y for 2nd-gen Intuos Pro large
Browse files Browse the repository at this point in the history
The HID descriptor for the 2nd-gen Intuos Pro large (PTH-860) contains
a typo which defines an incorrect logical maximum Y value. This causes
a small portion of the bottom of the tablet to become unusable (both
because the area is below the "bottom" of the tablet and because
'wacom_wac_event' ignores out-of-range values). It also results in a
skewed aspect ratio.

To fix this, we add a quirk to 'wacom_usage_mapping' which overwrites
the data with the correct value.

Signed-off-by: Jason Gerecke <[email protected]>
CC: [email protected] # v4.10+
Signed-off-by: Jiri Kosina <[email protected]>
  • Loading branch information
jigpu authored and Jiri Kosina committed Jun 20, 2018
1 parent ebeaa36 commit d471b6b
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions drivers/hid/wacom_sys.c
Original file line number Diff line number Diff line change
Expand Up @@ -395,6 +395,14 @@ static void wacom_usage_mapping(struct hid_device *hdev,
}
}

/* 2nd-generation Intuos Pro Large has incorrect Y maximum */
if (hdev->vendor == USB_VENDOR_ID_WACOM &&
hdev->product == 0x0358 &&
WACOM_PEN_FIELD(field) &&
wacom_equivalent_usage(usage->hid) == HID_GD_Y) {
field->logical_maximum = 43200;
}

switch (usage->hid) {
case HID_GD_X:
features->x_max = field->logical_maximum;
Expand Down

0 comments on commit d471b6b

Please sign in to comment.