Convert cluster test to a testable Go example. #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the test to be goexample complient.
iwasaki-kenta
suggested changes
Jun 26, 2018
examples/basic/setup_test.go
Outdated
| time.Sleep(1 * time.Second) | ||
|
|
||
| if result := nodes[0].PopMessage(); result != nil { | ||
| glog.Errorf("Expected nothing in node 0, got %v", result) |
There was a problem hiding this comment.
Lowercase and no punctuation for error messages.
examples/basic/setup_test.go
Outdated
| } | ||
| for i := 1; i < len(nodes); i++ { | ||
| if result := nodes[i].PopMessage(); result == nil { | ||
| fmt.Printf("Expected a message in node %d but it was blank", i) |
There was a problem hiding this comment.
Errorf and code styling.
There was a problem hiding this comment.
This comment guideline pretty long, give me a minute to go through it
iwasaki-kenta
approved these changes
Jun 26, 2018
iwasaki-kenta
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converted the simple cluster test to be goexample compliant:
https://blog.golang.org/examples
Usage: